fix: address gemini review - OnDelete strategy and log invalid endpoint

- Change seaweedfs-mount DaemonSet updateStrategy from RollingUpdate to OnDelete
  in seaweedfs-csi.yaml for consistency with values.yaml (safer for active mounts)
- Add warning log when invalid mountEndpoint is provided to aid debugging

2 files changed, 6 insertions, 4 deletions

diff --git a/deploy/kubernetes/seaweedfs-csi.yaml b/deploy/kubernetes/seaweedfs-csi.yaml
index 9fb140b..41062e1 100644
--- a/deploy/kubernetes/seaweedfs-csi.yaml
+++ b/deploy/kubernetes/seaweedfs-csi.yaml
@@ -356,10 +356,10 @@ spec:
   selector:
     matchLabels:
       app: seaweedfs-mount
+  # Use OnDelete strategy since mount service is not yet resilient to its own restarts.
+  # This allows manual, controlled updates to prevent automated disruption of active mounts.
   updateStrategy:
-    type: RollingUpdate
-    rollingUpdate:
-      maxUnavailable: 25%
+    type: OnDelete
   template:
     metadata:
       labels:
diff --git a/pkg/driver/driver.go b/pkg/driver/driver.go
index 6bdcc3b..84052ef 100644
--- a/pkg/driver/driver.go
+++ b/pkg/driver/driver.go
@@ -62,7 +62,9 @@ func NewSeaweedFsDriver(name, filer, nodeID, endpoint, mountEndpoint string, ena
 	volumeSocketDir := mountmanager.DefaultSocketDir
 	if mountEndpoint != "" {
 		_, address, err := mountmanager.ParseEndpoint(mountEndpoint)
-		if err == nil && address != "" {
+		if err != nil {
+			glog.Warningf("invalid mount endpoint %q, using default socket directory %q: %v", mountEndpoint, volumeSocketDir, err)
+		} else if address != "" {
 			volumeSocketDir = filepath.Dir(address)
 		}
 	}