fix: address PR review comments

- Set localSocket in rebuildVolumeFromStaging to fix invalid gRPC target
- Use SHA256 hash (16 hex chars) in LocalSocketPath to minimize collision risk
- Update GitHub Actions to latest versions (checkout@v4, metadata-action@v5, etc.)
- Fix volumeMounts/volumes conditional mismatch in helm templates
- Add documentation for mountService defaults in values.yaml

3 files changed, 20 insertions, 7 deletions

diff --git a/deploy/helm/seaweedfs-csi-driver/templates/daemonset-mount.yaml b/deploy/helm/seaweedfs-csi-driver/templates/daemonset-mount.yaml
index 31b3508..16a2f2d 100644
--- a/deploy/helm/seaweedfs-csi-driver/templates/daemonset-mount.yaml
+++ b/deploy/helm/seaweedfs-csi-driver/templates/daemonset-mount.yaml
@@ -50,7 +50,7 @@ spec:
               mountPath: /dev
             - name: cache
               mountPath: /var/cache/seaweedfs
-            {{- if and $mountEndpoint $mountSocketDir }}
+            {{- if and $mountEndpoint $mountSocketDir $mountHostPath }}
             - name: mount-socket-dir
               mountPath: {{ $mountSocketDir }}
             {{- end }}
@@ -69,7 +69,7 @@ spec:
             path: /dev
         - name: cache
           emptyDir: {}
-        {{- if and $mountEndpoint $mountHostPath }}
+        {{- if and $mountEndpoint $mountSocketDir $mountHostPath }}
         - name: mount-socket-dir
           hostPath:
             path: {{ $mountHostPath }}
diff --git a/deploy/helm/seaweedfs-csi-driver/templates/daemonset.yaml b/deploy/helm/seaweedfs-csi-driver/templates/daemonset.yaml
index bec6d26..f3e97c3 100644
--- a/deploy/helm/seaweedfs-csi-driver/templates/daemonset.yaml
+++ b/deploy/helm/seaweedfs-csi-driver/templates/daemonset.yaml
@@ -134,7 +134,7 @@ spec:
             {{- end }}
             - name: cache
               mountPath: /var/cache/seaweedfs
-            {{- if and $mountEndpoint $mountSocketDir }}
+            {{- if and $mountEndpoint $mountSocketDir $mountHostPath }}
             - name: mount-socket-dir
               mountPath: {{ $mountSocketDir }}
             {{- end }}
@@ -233,7 +233,7 @@ spec:
           secret:
             secretName: {{ .Values.tlsSecret }}
         {{- end }}
-        {{- if and $mountEndpoint $mountHostPath }}
+        {{- if and $mountEndpoint $mountSocketDir $mountHostPath }}
         - name: mount-socket-dir
           hostPath:
             path: {{ $mountHostPath }}
diff --git a/deploy/helm/seaweedfs-csi-driver/values.yaml b/deploy/helm/seaweedfs-csi-driver/values.yaml
index 224a169..e2de520 100644
--- a/deploy/helm/seaweedfs-csi-driver/values.yaml
+++ b/deploy/helm/seaweedfs-csi-driver/values.yaml
@@ -71,11 +71,21 @@ seaweedfsCsiPlugin:
       add: ["SYS_ADMIN"]
     allowPrivilegeEscalation: true
 
+# Mount Service Configuration
+# The mount service runs as a separate DaemonSet to provide mount resilience.
+# When enabled, FUSE mounts survive CSI driver restarts/upgrades.
+# The node.mountEndpoint, node.mountSocketDir, and node.mountHostPath values
+# default to the corresponding mountService.* values when left empty.
 mountService:
+  # Set to true (default) for mount resilience - mounts survive CSI driver restarts
+  # Set to false to disable the separate mount service (mounts managed by CSI driver directly)
   enabled: true
   image:  chrislusf/seaweedfs-mount:latest
+  # Endpoint for communication between CSI driver and mount service
   endpoint: unix:///var/lib/seaweedfs-mount/seaweedfs-mount.sock
+  # Host directory for mount service socket files
   hostPath: /var/lib/seaweedfs-mount
+  # Container path where socket directory is mounted
   socketDir: /var/lib/seaweedfs-mount
   securityContext:
     privileged: true
@@ -114,9 +124,12 @@ dataLocality: "none"
 node:
   # Deploy node daemonset
   enabled: true
-  mountEndpoint: ""
-  mountSocketDir: ""
-  mountHostPath: ""
+  # Mount service connection settings for the CSI node driver.
+  # When empty (default), these inherit from mountService.* values above.
+  # Only set these to override the mountService defaults.
+  mountEndpoint: ""    # defaults to mountService.endpoint
+  mountSocketDir: ""   # defaults to mountService.socketDir
+  mountHostPath: ""    # defaults to mountService.hostPath
   # When seaweedfs-csi-driver-node pod on node is recreated, all pods on same node using seaweed-csi PV will stop working.
   # For safe update set updateStrategy.type: OnDelete and manually move pods who use seaweed-csi PV, then delete  seaweedfs-csi-driver-node damonset pod
   updateStrategy: