From 70ad54f12e2e1bbf0a841b2604f150464fab1e8f Mon Sep 17 00:00:00 2001 From: chrislusf Date: Sat, 6 Dec 2025 12:02:18 -0800 Subject: fix: address PR review comments - Set localSocket in rebuildVolumeFromStaging to fix invalid gRPC target - Use SHA256 hash (16 hex chars) in LocalSocketPath to minimize collision risk - Update GitHub Actions to latest versions (checkout@v4, metadata-action@v5, etc.) - Fix volumeMounts/volumes conditional mismatch in helm templates - Add documentation for mountService defaults in values.yaml --- .github/workflows/versioned_release.yaml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to '.github') diff --git a/.github/workflows/versioned_release.yaml b/.github/workflows/versioned_release.yaml index 91e8241..61b3faf 100644 --- a/.github/workflows/versioned_release.yaml +++ b/.github/workflows/versioned_release.yaml @@ -16,11 +16,11 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Docker meta (csi-driver) id: docker_meta_csi - uses: docker/metadata-action@v3 + uses: docker/metadata-action@v5 with: images: | chrislusf/seaweedfs-csi-driver @@ -35,7 +35,7 @@ jobs: - name: Docker meta (mount-service) id: docker_meta_mount - uses: docker/metadata-action@v3 + uses: docker/metadata-action@v5 with: images: | chrislusf/seaweedfs-mount @@ -60,16 +60,16 @@ jobs: run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" | sed 's/\//_/g' >> $GITHUB_ENV - name: Setup QEMU - uses: docker/setup-qemu-action@v1 + uses: docker/setup-qemu-action@v3 - name: Setup Docker Buildx - uses: docker/setup-buildx-action@v1 + uses: docker/setup-buildx-action@v3 with: buildkitd-flags: "--debug" - name: Login to DockerHub # if: ${{ startsWith(github.ref, 'refs/tags/') }} - uses: docker/login-action@v2 + uses: docker/login-action@v3 with: # username: ${{ secrets.DOCKERHUB_USERNAME }} username: chrislusf @@ -77,7 +77,7 @@ jobs: - name: Build csi-driver image # if: ${{ startsWith(github.ref, 'refs/tags/') }} - uses: docker/build-push-action@v2 + uses: docker/build-push-action@v6 with: context: . push: ${{ github.event_name != 'pull_request' }} @@ -87,7 +87,7 @@ jobs: labels: ${{ steps.docker_meta_csi.outputs.labels }} - name: Build mount-service image - uses: docker/build-push-action@v2 + uses: docker/build-push-action@v6 with: context: . push: ${{ github.event_name != 'pull_request' }} -- cgit v1.2.3