From 41a32d25ef30f4066e712e9bf52f004632558081 Mon Sep 17 00:00:00 2001 From: chrislusf Date: Sat, 6 Dec 2025 12:26:43 -0800 Subject: fix: address gemini review - permissions and process stop - Change cacheDir permissions from 0750 to 0755 for non-root access - Change targetPath (mount point) permissions from 0750 to 0755 - Remove ineffective os.ErrProcessDone checks (not exported in os package) --- pkg/mountmanager/manager.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/mountmanager/manager.go b/pkg/mountmanager/manager.go index 1bdeb3e..161f795 100644 --- a/pkg/mountmanager/manager.go +++ b/pkg/mountmanager/manager.go @@ -140,7 +140,7 @@ func (m *Manager) startMount(req *MountRequest) (*mountEntry, error) { if cacheDir == "" { return nil, errors.New("cacheDir is required") } - if err := os.MkdirAll(cacheDir, 0750); err != nil { + if err := os.MkdirAll(cacheDir, 0755); err != nil { return nil, fmt.Errorf("creating cache dir: %w", err) } @@ -189,7 +189,7 @@ func ensureTargetClean(targetPath string) error { } // Ensure the path exists and is a directory. - return os.MkdirAll(targetPath, 0750) + return os.MkdirAll(targetPath, 0755) } func validateMountRequest(req *MountRequest) error { @@ -266,7 +266,7 @@ func (p *weedMountProcess) wait() { } func (p *weedMountProcess) stop() error { - if err := p.cmd.Process.Signal(syscall.SIGTERM); err != nil && err != os.ErrProcessDone { + if err := p.cmd.Process.Signal(syscall.SIGTERM); err != nil { glog.Warningf("sending SIGTERM to weed mount failed: %v", err) } @@ -276,7 +276,7 @@ func (p *weedMountProcess) stop() error { case <-time.After(5 * time.Second): } - if err := p.cmd.Process.Kill(); err != nil && err != os.ErrProcessDone { + if err := p.cmd.Process.Kill(); err != nil { glog.Warningf("killing weed mount failed: %v", err) } -- cgit v1.2.3