From 62bd056a3427738f0bebd9ca405d84e29275755b Mon Sep 17 00:00:00 2001 From: chrislusf Date: Sat, 6 Dec 2025 12:13:31 -0800 Subject: fix: address gemini-code-assist review comments - Change mountService updateStrategy from RollingUpdate to OnDelete (mount service not yet resilient to its own restarts) - Change mountService image from :latest to :dev for consistency - Fix defer os.RemoveAll: explicitly remove cache dir after process stops to avoid removing while process might still be running --- deploy/helm/seaweedfs-csi-driver/values.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'deploy') diff --git a/deploy/helm/seaweedfs-csi-driver/values.yaml b/deploy/helm/seaweedfs-csi-driver/values.yaml index e2de520..eed5b5e 100644 --- a/deploy/helm/seaweedfs-csi-driver/values.yaml +++ b/deploy/helm/seaweedfs-csi-driver/values.yaml @@ -80,7 +80,7 @@ mountService: # Set to true (default) for mount resilience - mounts survive CSI driver restarts # Set to false to disable the separate mount service (mounts managed by CSI driver directly) enabled: true - image: chrislusf/seaweedfs-mount:latest + image: chrislusf/seaweedfs-mount:dev # Endpoint for communication between CSI driver and mount service endpoint: unix:///var/lib/seaweedfs-mount/seaweedfs-mount.sock # Host directory for mount service socket files @@ -92,10 +92,10 @@ mountService: capabilities: add: ["SYS_ADMIN"] allowPrivilegeEscalation: true + # Use OnDelete strategy since mount service is not yet resilient to its own restarts. + # This allows manual, controlled updates to prevent automated disruption of active mounts. updateStrategy: - type: RollingUpdate - rollingUpdate: - maxUnavailable: 25% + type: OnDelete affinity: {} tolerations: resources: {} -- cgit v1.2.3