From f292fb147fb04f857596a0c7bd2ddfef788e52e2 Mon Sep 17 00:00:00 2001
From: chrislusf <chris.lu@gmail.com>
Date: Fri, 5 Dec 2025 18:44:43 -0800
Subject: fix: address code review feedback

- CRITICAL: Make socket path configurable based on mountEndpoint
  - Added volumeSocketDir field to SeaweedFsDriver
  - LocalSocketPath now accepts baseDir parameter
  - Derived from mountEndpoint for user-configurable socket paths

- HIGH: Pin seaweedfs version in Dockerfiles for reproducible builds
  - Added SEAWEEDFS_VERSION build arg (default: 3.80)
  - Clone specific tag instead of master

- HIGH: Fix Dockerfile.dev to use local context instead of personal fork
  - Removed hardcoded zemul/seaweedfs-csi-driver clone
  - Now uses COPY . . for local development

- HIGH: Change :latest to :dev in kubernetes manifests
  - Mutable :latest tag replaced with :dev for predictability

- MEDIUM: Remove Aliyun mirror from Dockerfile.dev
  - Region-specific mirrors shouldn't be in general-purpose files

- MEDIUM: Improve error handling in client.go
  - Now reports read errors when failing to read error response body

- MEDIUM: Fix inconsistent error return in manager.go
  - Return nil instead of empty struct on error (Go idiom)
---
 deploy/kubernetes/seaweedfs-csi.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'deploy')

diff --git a/deploy/kubernetes/seaweedfs-csi.yaml b/deploy/kubernetes/seaweedfs-csi.yaml
index 2fc4f9b..9fb140b 100644
--- a/deploy/kubernetes/seaweedfs-csi.yaml
+++ b/deploy/kubernetes/seaweedfs-csi.yaml
@@ -216,7 +216,7 @@ spec:
               add:
               - SYS_ADMIN
             privileged: true
-          image: chrislusf/seaweedfs-csi-driver:latest
+          image: chrislusf/seaweedfs-csi-driver:dev
           imagePullPolicy: IfNotPresent
           args:
             - --endpoint=$(CSI_ENDPOINT)
@@ -375,7 +375,7 @@ spec:
               add:
                 - SYS_ADMIN
             privileged: true
-          image: chrislusf/seaweedfs-mount:latest
+          image: chrislusf/seaweedfs-mount:dev
           imagePullPolicy: IfNotPresent
           args:
             - --endpoint=$(MOUNT_ENDPOINT)
@@ -444,7 +444,7 @@ spec:
       containers:
         # SeaweedFs Plugin (controller)
         - name: seaweedfs-csi-plugin
-          image: chrislusf/seaweedfs-csi-driver:latest
+          image: chrislusf/seaweedfs-csi-driver:dev
           imagePullPolicy: IfNotPresent
           args :
             - --endpoint=$(CSI_ENDPOINT)
-- 
cgit v1.2.3