From f292fb147fb04f857596a0c7bd2ddfef788e52e2 Mon Sep 17 00:00:00 2001 From: chrislusf Date: Fri, 5 Dec 2025 18:44:43 -0800 Subject: fix: address code review feedback - CRITICAL: Make socket path configurable based on mountEndpoint - Added volumeSocketDir field to SeaweedFsDriver - LocalSocketPath now accepts baseDir parameter - Derived from mountEndpoint for user-configurable socket paths - HIGH: Pin seaweedfs version in Dockerfiles for reproducible builds - Added SEAWEEDFS_VERSION build arg (default: 3.80) - Clone specific tag instead of master - HIGH: Fix Dockerfile.dev to use local context instead of personal fork - Removed hardcoded zemul/seaweedfs-csi-driver clone - Now uses COPY . . for local development - HIGH: Change :latest to :dev in kubernetes manifests - Mutable :latest tag replaced with :dev for predictability - MEDIUM: Remove Aliyun mirror from Dockerfile.dev - Region-specific mirrors shouldn't be in general-purpose files - MEDIUM: Improve error handling in client.go - Now reports read errors when failing to read error response body - MEDIUM: Fix inconsistent error return in manager.go - Return nil instead of empty struct on error (Go idiom) --- pkg/driver/mounter.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'pkg/driver/mounter.go') diff --git a/pkg/driver/mounter.go b/pkg/driver/mounter.go index d86d82e..b96f4b8 100644 --- a/pkg/driver/mounter.go +++ b/pkg/driver/mounter.go @@ -68,7 +68,7 @@ func (m *mountServiceMounter) Mount(target string) (Unmounter, error) { cacheBase = os.TempDir() } cacheDir := filepath.Join(cacheBase, m.volumeID) - localSocket := mountmanager.LocalSocketPath(m.volumeID) + localSocket := mountmanager.LocalSocketPath(m.driver.volumeSocketDir, m.volumeID) args, err := m.buildMountArgs(target, cacheDir, localSocket, filers) if err != nil { -- cgit v1.2.3