From 4f18bece434aaa7943a61533241ec6a26f58b9a2 Mon Sep 17 00:00:00 2001 From: chrislusf Date: Fri, 5 Dec 2025 18:44:43 -0800 Subject: fix: address code review feedback - CRITICAL: Make socket path configurable based on mountEndpoint - Added volumeSocketDir field to SeaweedFsDriver - LocalSocketPath now accepts baseDir parameter - Derived from mountEndpoint for user-configurable socket paths - HIGH: Pin seaweedfs version in Dockerfiles for reproducible builds - Added SEAWEEDFS_VERSION build arg (default: 3.80) - Clone specific tag instead of master - HIGH: Fix Dockerfile.dev to use local context instead of personal fork - Removed hardcoded zemul/seaweedfs-csi-driver clone - Now uses COPY . . for local development - HIGH: Change :latest to :dev in kubernetes manifests - Mutable :latest tag replaced with :dev for predictability - MEDIUM: Remove Aliyun mirror from Dockerfile.dev - Region-specific mirrors shouldn't be in general-purpose files - MEDIUM: Improve error handling in client.go - Now reports read errors when failing to read error response body - MEDIUM: Fix inconsistent error return in manager.go - Return nil instead of empty struct on error (Go idiom) --- pkg/driver/volume.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'pkg/driver/volume.go') diff --git a/pkg/driver/volume.go b/pkg/driver/volume.go index 9e258a8..18d5c2a 100644 --- a/pkg/driver/volume.go +++ b/pkg/driver/volume.go @@ -29,7 +29,7 @@ func NewVolume(volumeID string, mounter Mounter, driver *SeaweedFsDriver) *Volum return &Volume{ VolumeId: volumeID, mounter: mounter, - localSocket: mountmanager.LocalSocketPath(volumeID), + localSocket: mountmanager.LocalSocketPath(driver.volumeSocketDir, volumeID), driver: driver, } } -- cgit v1.2.3