From 62bd056a3427738f0bebd9ca405d84e29275755b Mon Sep 17 00:00:00 2001 From: chrislusf Date: Sat, 6 Dec 2025 12:13:31 -0800 Subject: fix: address gemini-code-assist review comments - Change mountService updateStrategy from RollingUpdate to OnDelete (mount service not yet resilient to its own restarts) - Change mountService image from :latest to :dev for consistency - Fix defer os.RemoveAll: explicitly remove cache dir after process stops to avoid removing while process might still be running --- pkg/mountmanager/manager.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'pkg/mountmanager/manager.go') diff --git a/pkg/mountmanager/manager.go b/pkg/mountmanager/manager.go index e4e4329..1bdeb3e 100644 --- a/pkg/mountmanager/manager.go +++ b/pkg/mountmanager/manager.go @@ -102,12 +102,15 @@ func (m *Manager) Unmount(req *UnmountRequest) (*UnmountResponse, error) { } } - defer os.RemoveAll(entry.cacheDir) - if err := entry.process.stop(); err != nil { return nil, err } + // Remove cache dir only after process has been successfully stopped + if err := os.RemoveAll(entry.cacheDir); err != nil { + glog.Warningf("failed to remove cache dir %s for volume %s: %v", entry.cacheDir, req.VolumeID, err) + } + glog.Infof("stopped weed mount process for volume %s at %s", req.VolumeID, entry.targetPath) return &UnmountResponse{}, nil } -- cgit v1.2.3