aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Lu <chris.lu@gmail.com>2021-02-04 01:30:14 -0800
committerChris Lu <chris.lu@gmail.com>2021-02-04 01:30:14 -0800
commitc3af72d950d93bfa0d42f9e2bf68d183c6285d73 (patch)
treecf170b86a8329b7b45cc37d0a101692f344d48ce
parentee4b208b8a92e1e3720827569e9bf768eb5580c8 (diff)
downloadseaweedfs-c3af72d950d93bfa0d42f9e2bf68d183c6285d73.tar.xz
seaweedfs-c3af72d950d93bfa0d42f9e2bf68d183c6285d73.zip
fier store: fix elastic search regression
fix https://github.com/chrislusf/seaweedfs/issues/1774
-rw-r--r--weed/filer/elastic/v7/elastic_store.go65
1 files changed, 16 insertions, 49 deletions
diff --git a/weed/filer/elastic/v7/elastic_store.go b/weed/filer/elastic/v7/elastic_store.go
index 14719e6ed..a16e5ebca 100644
--- a/weed/filer/elastic/v7/elastic_store.go
+++ b/weed/filer/elastic/v7/elastic_store.go
@@ -101,7 +101,7 @@ func (store *ElasticStore) ListDirectoryPrefixedEntries(ctx context.Context, dir
}
func (store *ElasticStore) InsertEntry(ctx context.Context, entry *filer.Entry) (err error) {
- index := getIndex(entry.FullPath)
+ index := getIndex(entry.FullPath, false)
dir, _ := entry.FullPath.DirAndName()
id := weed_util.Md5String([]byte(entry.FullPath))
esEntry := &ESEntry{
@@ -131,7 +131,7 @@ func (store *ElasticStore) UpdateEntry(ctx context.Context, entry *filer.Entry)
}
func (store *ElasticStore) FindEntry(ctx context.Context, fullpath weed_util.FullPath) (entry *filer.Entry, err error) {
- index := getIndex(fullpath)
+ index := getIndex(fullpath, false)
id := weed_util.Md5String([]byte(fullpath))
searchResult, err := store.client.Get().
Index(index).
@@ -154,7 +154,7 @@ func (store *ElasticStore) FindEntry(ctx context.Context, fullpath weed_util.Ful
}
func (store *ElasticStore) DeleteEntry(ctx context.Context, fullpath weed_util.FullPath) (err error) {
- index := getIndex(fullpath)
+ index := getIndex(fullpath, false)
id := weed_util.Md5String([]byte(fullpath))
if strings.Count(string(fullpath), "/") == 1 {
return store.deleteIndex(ctx, index)
@@ -198,47 +198,13 @@ func (store *ElasticStore) DeleteFolderChildren(ctx context.Context, fullpath we
}
func (store *ElasticStore) ListDirectoryEntries(ctx context.Context, dirPath weed_util.FullPath, startFileName string, includeStartFile bool, limit int64, eachEntryFunc filer.ListEachEntryFunc) (lastFileName string, err error) {
- if string(dirPath) == "/" {
- return store.listRootDirectoryEntries(ctx, startFileName, includeStartFile, limit, eachEntryFunc)
- }
return store.listDirectoryEntries(ctx, dirPath, startFileName, includeStartFile, limit, eachEntryFunc)
}
-func (store *ElasticStore) listRootDirectoryEntries(ctx context.Context, startFileName string, inclusive bool, limit int64, eachEntryFunc filer.ListEachEntryFunc) (lastFileName string, err error) {
- indexResult, err := store.client.CatIndices().Do(ctx)
- if err != nil {
- glog.Errorf("list indices %v.", err)
- return
- }
- for _, index := range indexResult {
- if index.Index == indexKV {
- continue
- }
- if strings.HasPrefix(index.Index, indexPrefix) {
- if entry, err := store.FindEntry(ctx,
- weed_util.FullPath("/"+strings.Replace(index.Index, indexPrefix, "", 1))); err == nil {
- fileName := getFileName(entry.FullPath)
- if fileName == startFileName && !inclusive {
- continue
- }
- limit--
- if limit < 0 {
- break
- }
- if !eachEntryFunc(entry) {
- break
- }
- lastFileName = fileName
- }
- }
- }
- return
-}
-
func (store *ElasticStore) listDirectoryEntries(
ctx context.Context, fullpath weed_util.FullPath, startFileName string, inclusive bool, limit int64, eachEntryFunc filer.ListEachEntryFunc) (lastFileName string, err error) {
first := true
- index := getIndex(fullpath)
+ index := getIndex(fullpath, true)
nextStart := ""
parentId := weed_util.Md5String([]byte(fullpath))
if _, err = store.client.Refresh(index).Do(ctx); err != nil {
@@ -277,7 +243,7 @@ func (store *ElasticStore) listDirectoryEntries(
return lastFileName, nil
}
nextStart = string(esEntry.Entry.FullPath)
- fileName := getFileName(esEntry.Entry.FullPath)
+ fileName := esEntry.Entry.FullPath.Name()
if fileName == startFileName && !inclusive {
continue
}
@@ -287,6 +253,9 @@ func (store *ElasticStore) listDirectoryEntries(
lastFileName = fileName
}
}
+ if len(result.Hits.Hits) < store.maxPageSize {
+ break
+ }
}
return
}
@@ -323,18 +292,16 @@ func (store *ElasticStore) Shutdown() {
store.client.Stop()
}
-func getIndex(fullpath weed_util.FullPath) string {
+func getIndex(fullpath weed_util.FullPath, isDirectory bool) string {
path := strings.Split(string(fullpath), "/")
- if len(path) > 1 {
- return indexPrefix + path[1]
+ if isDirectory && len(path) >= 2 {
+ return indexPrefix + strings.ToLower(path[1])
}
- return ""
-}
-
-func getFileName(fullpath weed_util.FullPath) string {
- path := strings.Split(string(fullpath), "/")
- if len(path) > 1 {
- return path[len(path)-1]
+ if len(path) > 2 {
+ return indexPrefix + strings.ToLower(path[1])
+ }
+ if len(path) == 2 {
+ return indexPrefix
}
return ""
}