diff options
| author | Guang Jiong Lou <7991675+27149chen@users.noreply.github.com> | 2024-10-22 23:46:18 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-10-22 08:46:18 -0700 |
| commit | 9369a88c5c659753aeced2c6aa62d0264632c2ea (patch) | |
| tree | d3bf81cfd07931153284566003ae8f5f7eb2a36a | |
| parent | 970059d4ce07f439a48429bee677881f097ac7b9 (diff) | |
| download | seaweedfs-9369a88c5c659753aeced2c6aa62d0264632c2ea.tar.xz seaweedfs-9369a88c5c659753aeced2c6aa62d0264632c2ea.zip | |
stop renaming worm files (#6154)
* stop renaming worm file
Signed-off-by: lou <alex1988@outlook.com>
* update after review
Signed-off-by: lou <alex1988@outlook.com>
* Update weed/server/filer_server_handlers_write.go
---------
Signed-off-by: lou <alex1988@outlook.com>
Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
| -rw-r--r-- | weed/mount/weedfs_rename.go | 14 | ||||
| -rw-r--r-- | weed/server/filer_server_handlers_write.go | 8 |
2 files changed, 19 insertions, 3 deletions
diff --git a/weed/mount/weedfs_rename.go b/weed/mount/weedfs_rename.go index f9fc85b3f..18ab427a2 100644 --- a/weed/mount/weedfs_rename.go +++ b/weed/mount/weedfs_rename.go @@ -3,15 +3,16 @@ package mount import ( "context" "fmt" + "io" + "strings" + "syscall" + "github.com/hanwen/go-fuse/v2/fs" "github.com/hanwen/go-fuse/v2/fuse" "github.com/seaweedfs/seaweedfs/weed/filer" "github.com/seaweedfs/seaweedfs/weed/glog" "github.com/seaweedfs/seaweedfs/weed/pb/filer_pb" "github.com/seaweedfs/seaweedfs/weed/util" - "io" - "strings" - "syscall" ) /** Rename a file @@ -160,6 +161,13 @@ func (wfs *WFS) Rename(cancel <-chan struct{}, in *fuse.RenameIn, oldName string } newPath := newDir.Child(newName) + if wfs.FilerConf != nil { + rule := wfs.FilerConf.MatchStorageRule(string(oldPath)) + if rule.Worm { + return fuse.EPERM + } + } + glog.V(4).Infof("dir Rename %s => %s", oldPath, newPath) // update remote filer diff --git a/weed/server/filer_server_handlers_write.go b/weed/server/filer_server_handlers_write.go index e745f04f2..75fd5984e 100644 --- a/weed/server/filer_server_handlers_write.go +++ b/weed/server/filer_server_handlers_write.go @@ -160,6 +160,14 @@ func (fs *FilerServer) move(ctx context.Context, w http.ResponseWriter, r *http. return } + rule := fs.filer.FilerConf.MatchStorageRule(src) + if rule.Worm { + // you cannot move a worm file or directory + err = fmt.Errorf("cannot move write-once entry from '%s' to '%s': operation not permitted", src, dst) + writeJsonError(w, r, http.StatusForbidden, err) + return + } + oldDir, oldName := srcPath.DirAndName() newDir, newName := dstPath.DirAndName() newName = util.Nvl(newName, oldName) |