diff options
| author | Chris Lu <chris.lu@gmail.com> | 2020-04-03 00:47:33 -0700 |
|---|---|---|
| committer | Chris Lu <chris.lu@gmail.com> | 2020-04-03 00:47:33 -0700 |
| commit | 4a5e381febc449d044fc51fdcf65bee55f21434f (patch) | |
| tree | 8621077ab72ee3e9261277b6d494e3fd1cab4009 | |
| parent | aaf5e658ccf788467effafabd3bfb4c7da4a5b18 (diff) | |
| download | seaweedfs-4a5e381febc449d044fc51fdcf65bee55f21434f.tar.xz seaweedfs-4a5e381febc449d044fc51fdcf65bee55f21434f.zip | |
fail fast if filer configured wrong masters
fix https://github.com/chrislusf/seaweedfs/issues/1257
| -rw-r--r-- | weed/server/filer_server.go | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/weed/server/filer_server.go b/weed/server/filer_server.go index 51b7b44d1..9a84fac99 100644 --- a/weed/server/filer_server.go +++ b/weed/server/filer_server.go @@ -11,6 +11,7 @@ import ( "google.golang.org/grpc" "github.com/chrislusf/seaweedfs/weed/operation" + "github.com/chrislusf/seaweedfs/weed/pb" "github.com/chrislusf/seaweedfs/weed/pb/filer_pb" "github.com/chrislusf/seaweedfs/weed/pb/master_pb" "github.com/chrislusf/seaweedfs/weed/stats" @@ -58,7 +59,6 @@ type FilerServer struct { // notifying clients clientChansLock sync.RWMutex clientChans map[string]chan *filer_pb.FullEventNotification - } func NewFilerServer(defaultMux, readonlyMux *http.ServeMux, option *FilerOption) (fs *FilerServer, err error) { @@ -117,6 +117,14 @@ func NewFilerServer(defaultMux, readonlyMux *http.ServeMux, option *FilerOption) } func maybeStartMetrics(fs *FilerServer, option *FilerOption) { + + for _, master := range option.Masters { + _, err := pb.ParseFilerGrpcAddress(master) + if err != nil { + glog.Fatalf("invalid master address %s: %v", master, err) + } + } + isConnected := false var metricsAddress string var metricsIntervalSec int |