aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKonstantin Lebedev <9497591+kmlebedev@users.noreply.github.com>2024-01-25 13:23:24 +0500
committerGitHub <noreply@github.com>2024-01-25 00:23:24 -0800
commit0f8e76bbd62c017c131c25aa8bdd580ef56b392b (patch)
treee7b9348782d0a415f57512841997d172d5296775
parenta6aee847b9b26fdd587ddbbd7823b1879fae5351 (diff)
downloadseaweedfs-0f8e76bbd62c017c131c25aa8bdd580ef56b392b.tar.xz
seaweedfs-0f8e76bbd62c017c131c25aa8bdd580ef56b392b.zip
fix: clean metric MasterReplicaPlacementMismatch for unregister volume (#5239)
-rw-r--r--weed/topology/topology.go4
1 files changed, 4 insertions, 0 deletions
diff --git a/weed/topology/topology.go b/weed/topology/topology.go
index 03d7570c1..0a4cb4050 100644
--- a/weed/topology/topology.go
+++ b/weed/topology/topology.go
@@ -19,6 +19,7 @@ import (
"github.com/seaweedfs/seaweedfs/weed/glog"
"github.com/seaweedfs/seaweedfs/weed/pb/master_pb"
"github.com/seaweedfs/seaweedfs/weed/sequence"
+ "github.com/seaweedfs/seaweedfs/weed/stats"
"github.com/seaweedfs/seaweedfs/weed/storage"
"github.com/seaweedfs/seaweedfs/weed/storage/needle"
"github.com/seaweedfs/seaweedfs/weed/storage/super_block"
@@ -273,6 +274,9 @@ func (t *Topology) RegisterVolumeLayout(v storage.VolumeInfo, dn *DataNode) {
}
func (t *Topology) UnRegisterVolumeLayout(v storage.VolumeInfo, dn *DataNode) {
glog.Infof("removing volume info: %+v from %v", v, dn.id)
+ if v.ReplicaPlacement.GetCopyCount() > 1 {
+ stats.MasterReplicaPlacementMismatch.WithLabelValues(v.Collection, v.Id.String()).Set(0)
+ }
diskType := types.ToDiskType(v.DiskType)
volumeLayout := t.GetVolumeLayout(v.Collection, v.ReplicaPlacement, v.Ttl, diskType)
volumeLayout.UnRegisterVolume(&v, dn)