diff options
| author | Chris Lu <chris.lu@gmail.com> | 2020-05-13 03:46:38 -0700 |
|---|---|---|
| committer | Chris Lu <chris.lu@gmail.com> | 2020-05-13 03:46:38 -0700 |
| commit | 3a5e4769cfe383ca5a3e3d4078b5e80120763f3b (patch) | |
| tree | 8785ef90b3fc1f4a249b5eb4753e5f8ab46dd17e | |
| parent | 015dd3a147cc6f1ca0bfc02ddcd74453fc08ebf6 (diff) | |
| download | seaweedfs-3a5e4769cfe383ca5a3e3d4078b5e80120763f3b.tar.xz seaweedfs-3a5e4769cfe383ca5a3e3d4078b5e80120763f3b.zip | |
prevent empty locations returned
fix https://github.com/chrislusf/seaweedfs/issues/1313
| -rw-r--r-- | weed/server/master_server_handlers.go | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/weed/server/master_server_handlers.go b/weed/server/master_server_handlers.go index 514d86800..ebcb7efd2 100644 --- a/weed/server/master_server_handlers.go +++ b/weed/server/master_server_handlers.go @@ -45,7 +45,7 @@ func (ms *MasterServer) dirLookupHandler(w http.ResponseWriter, r *http.Request) vid = fileId[0:commaSep] } } - collection := r.FormValue("collection") //optional, but can be faster if too many collections + collection := r.FormValue("collection") // optional, but can be faster if too many collections location := ms.findVolumeLocation(collection, vid) httpStatus := http.StatusOK if location.Error != "" || location.Locations == nil { @@ -72,9 +72,6 @@ func (ms *MasterServer) findVolumeLocation(collection, vid string) operation.Loo for _, loc := range machines { locations = append(locations, operation.Location{Url: loc.Url(), PublicUrl: loc.PublicUrl}) } - if locations == nil { - err = fmt.Errorf("volume id %s not found", vid) - } } } else { machines, getVidLocationsErr := ms.MasterClient.GetVidLocations(vid) @@ -83,6 +80,9 @@ func (ms *MasterServer) findVolumeLocation(collection, vid string) operation.Loo } err = getVidLocationsErr } + if len(locations) == 0 && err == nil { + err = fmt.Errorf("volume id %s not found", vid) + } ret := operation.LookupResult{ VolumeId: vid, Locations: locations, |