aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Lu <chrislusf@users.noreply.github.com>2021-07-21 12:37:20 -0700
committerGitHub <noreply@github.com>2021-07-21 12:37:20 -0700
commitcc32436d63a433b436ab74c99fe7246242a83716 (patch)
treefdc4c9432d34e1799d909f2fced64036d2a3886b
parent67537ff05be4840bc66359098ef0ed0e09265d26 (diff)
parente0c7708b038a7dcfc8127d2b9c57bf7c838853df (diff)
downloadseaweedfs-cc32436d63a433b436ab74c99fe7246242a83716.tar.xz
seaweedfs-cc32436d63a433b436ab74c99fe7246242a83716.zip
Merge pull request #2209 from combineads/fuse_option
Fix error handling
-rw-r--r--weed/command/fuse.go20
1 files changed, 10 insertions, 10 deletions
diff --git a/weed/command/fuse.go b/weed/command/fuse.go
index 609892b5b..a0dcaa86c 100644
--- a/weed/command/fuse.go
+++ b/weed/command/fuse.go
@@ -62,7 +62,7 @@ func runFuse(cmd *Command, args []string) bool {
option.WriteByte(rawArgs[i])
}
- // single quote separator read option until next single quote
+ // single quote separator read option until next single quote
} else if rawArgs[i] == '\'' {
for i++; i < rawArgsLen && rawArgs[i] != '\''; i++ {
option.WriteByte(rawArgs[i])
@@ -109,7 +109,7 @@ func runFuse(cmd *Command, args []string) bool {
case "filer.path":
mountOptions.filerMountRootPath = &parameter.value
case "dirAutoCreate":
- if parsed, err := strconv.ParseBool(parameter.value); err != nil {
+ if parsed, err := strconv.ParseBool(parameter.value); err == nil {
mountOptions.dirAutoCreate = &parsed
} else {
panic(fmt.Errorf("dirAutoCreate: %s", err))
@@ -121,14 +121,14 @@ func runFuse(cmd *Command, args []string) bool {
case "disk":
mountOptions.diskType = &parameter.value
case "ttl":
- if parsed, err := strconv.ParseInt(parameter.value, 0, 32); err != nil {
+ if parsed, err := strconv.ParseInt(parameter.value, 0, 32); err == nil {
intValue := int(parsed)
mountOptions.ttlSec = &intValue
} else {
panic(fmt.Errorf("ttl: %s", err))
}
case "chunkSizeLimitMB":
- if parsed, err := strconv.ParseInt(parameter.value, 0, 32); err != nil {
+ if parsed, err := strconv.ParseInt(parameter.value, 0, 32); err == nil {
intValue := int(parsed)
mountOptions.chunkSizeLimitMB = &intValue
} else {
@@ -136,7 +136,7 @@ func runFuse(cmd *Command, args []string) bool {
}
case "concurrentWriters":
i++
- if parsed, err := strconv.ParseInt(parameter.value, 0, 32); err != nil {
+ if parsed, err := strconv.ParseInt(parameter.value, 0, 32); err == nil {
intValue := int(parsed)
mountOptions.concurrentWriters = &intValue
} else {
@@ -145,7 +145,7 @@ func runFuse(cmd *Command, args []string) bool {
case "cacheDir":
mountOptions.cacheDir = &parameter.value
case "cacheCapacityMB":
- if parsed, err := strconv.ParseInt(parameter.value, 0, 64); err != nil {
+ if parsed, err := strconv.ParseInt(parameter.value, 0, 64); err == nil {
mountOptions.cacheSizeMB = &parsed
} else {
panic(fmt.Errorf("cacheCapacityMB: %s", err))
@@ -153,7 +153,7 @@ func runFuse(cmd *Command, args []string) bool {
case "dataCenter":
mountOptions.dataCenter = &parameter.value
case "allowOthers":
- if parsed, err := strconv.ParseBool(parameter.value); err != nil {
+ if parsed, err := strconv.ParseBool(parameter.value); err == nil {
mountOptions.allowOthers = &parsed
} else {
panic(fmt.Errorf("allowOthers: %s", err))
@@ -161,7 +161,7 @@ func runFuse(cmd *Command, args []string) bool {
case "umask":
mountOptions.umaskString = &parameter.value
case "nonempty":
- if parsed, err := strconv.ParseBool(parameter.value); err != nil {
+ if parsed, err := strconv.ParseBool(parameter.value); err == nil {
mountOptions.nonempty = &parsed
} else {
panic(fmt.Errorf("nonempty: %s", err))
@@ -173,7 +173,7 @@ func runFuse(cmd *Command, args []string) bool {
case "map.gid":
mountOptions.gidMap = &parameter.value
case "readOnly":
- if parsed, err := strconv.ParseBool(parameter.value); err != nil {
+ if parsed, err := strconv.ParseBool(parameter.value); err == nil {
mountOptions.readOnly = &parsed
} else {
panic(fmt.Errorf("readOnly: %s", err))
@@ -183,7 +183,7 @@ func runFuse(cmd *Command, args []string) bool {
case "memprofile":
mountMemProfile = &parameter.value
case "readRetryTime":
- if parsed, err := time.ParseDuration(parameter.value); err != nil {
+ if parsed, err := time.ParseDuration(parameter.value); err == nil {
mountReadRetryTime = &parsed
} else {
panic(fmt.Errorf("readRetryTime: %s", err))