diff options
| author | LazyDBA247-Anyvision <yonin@anyvision.co> | 2021-01-14 08:14:21 +0200 |
|---|---|---|
| committer | LazyDBA247-Anyvision <yonin@anyvision.co> | 2021-01-14 08:14:21 +0200 |
| commit | 8eed763b97acc3af6420f7e370c3e61ecc7befe2 (patch) | |
| tree | 940f31a7ebe983d4a3dc5fadc711a147873d08d0 | |
| parent | f17aa1d06c10c59124b08ca92480e4bba9b324b8 (diff) | |
| download | seaweedfs-8eed763b97acc3af6420f7e370c3e61ecc7befe2.tar.xz seaweedfs-8eed763b97acc3af6420f7e370c3e61ecc7befe2.zip | |
better mysql connection pool management
adding SetConnMaxLifetime configuration (https://golang.org/pkg/database/sql/#DB.SetConnMaxLifetime)
to enable refresh of connections.
| -rw-r--r-- | weed/command/scaffold.go | 1 | ||||
| -rw-r--r-- | weed/filer/mysql/mysql_store.go | 6 |
2 files changed, 5 insertions, 2 deletions
diff --git a/weed/command/scaffold.go b/weed/command/scaffold.go index f43a9d143..887c9883f 100644 --- a/weed/command/scaffold.go +++ b/weed/command/scaffold.go @@ -118,6 +118,7 @@ password = "" database = "" # create or use an existing database connection_max_idle = 2 connection_max_open = 100 +connection_max_lifetime_seconds = 0 interpolateParams = false [postgres] # or cockroachdb diff --git a/weed/filer/mysql/mysql_store.go b/weed/filer/mysql/mysql_store.go index 5bc132980..62b9b287a 100644 --- a/weed/filer/mysql/mysql_store.go +++ b/weed/filer/mysql/mysql_store.go @@ -35,12 +35,13 @@ func (store *MysqlStore) Initialize(configuration util.Configuration, prefix str configuration.GetString(prefix+"database"), configuration.GetInt(prefix+"connection_max_idle"), configuration.GetInt(prefix+"connection_max_open"), + configuration.GetInt(prefix+"connection_max_lifetime_seconds"), configuration.GetBool(prefix+"interpolateParams"), ) } -func (store *MysqlStore) initialize(user, password, hostname string, port int, database string, maxIdle, maxOpen int, - interpolateParams bool) (err error) { +func (store *MysqlStore) initialize(user, password, hostname string, port int, database string, maxIdle, maxOpen, + maxLifetimeSeconds int, interpolateParams bool) (err error) { // store.SqlInsert = "INSERT INTO filemeta (dirhash,name,directory,meta) VALUES(?,?,?,?)" store.SqlUpdate = "UPDATE filemeta SET meta=? WHERE dirhash=? AND name=? AND directory=?" @@ -65,6 +66,7 @@ func (store *MysqlStore) initialize(user, password, hostname string, port int, d store.DB.SetMaxIdleConns(maxIdle) store.DB.SetMaxOpenConns(maxOpen) + store.DB.SetConnMaxLifetime(maxLifetimeSeconds*time.Second) if err = store.DB.Ping(); err != nil { return fmt.Errorf("connect to %s error:%v", sqlUrl, err) |