diff options
| author | Chris Lu <chrislusf@users.noreply.github.com> | 2022-02-07 11:33:58 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-02-07 11:33:58 -0800 |
| commit | f46763d74f618be2308bf77770bfd8384ce8cf0e (patch) | |
| tree | fa96355ba63e1bcc94926d9fc29c81e121e36bd3 | |
| parent | 1b7fb3ce841617da442ac79881983a7a01bd3204 (diff) | |
| parent | ef541972f8c456c003cfcef7ceefb450dedf808b (diff) | |
| download | seaweedfs-f46763d74f618be2308bf77770bfd8384ce8cf0e.tar.xz seaweedfs-f46763d74f618be2308bf77770bfd8384ce8cf0e.zip | |
Merge pull request #2644 from kmlebedev/vacum_fsync
updated needle with fsync
| -rw-r--r-- | weed/storage/volume_vacuum.go | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/weed/storage/volume_vacuum.go b/weed/storage/volume_vacuum.go index d686e2b09..56e8beddb 100644 --- a/weed/storage/volume_vacuum.go +++ b/weed/storage/volume_vacuum.go @@ -289,6 +289,9 @@ func (v *Volume) makeupDiff(newDatFileName, newIdxFileName, oldDatFileName, oldI return fmt.Errorf("ReadNeedleBlob %s key %d offset %d size %d failed: %v", oldDatFile.Name(), key, increIdxEntry.offset.ToActualOffset(), increIdxEntry.size, err) } dstDatBackend.Write(needleBytes) + if err := dstDatBackend.Sync(); err != nil { + return fmt.Errorf("cannot sync needle %s: %v", dstDatBackend.File.Name(), err) + } util.Uint32toBytes(idxEntryBytes[8:12], uint32(offset/NeedlePaddingSize)) } else { //deleted needle //fakeDelNeedle 's default Data field is nil @@ -308,6 +311,12 @@ func (v *Volume) makeupDiff(newDatFileName, newIdxFileName, oldDatFileName, oldI newIdxFileName, err) } _, err = idx.Write(idxEntryBytes) + if err != nil { + return fmt.Errorf("cannot write indexfile %s: %v", newIdxFileName, err) + } + if err := idx.Sync(); err != nil { + return fmt.Errorf("cannot sync indexfile %s: %v", newIdxFileName, err) + } } return nil |