aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorchrislu <chris.lu@gmail.com>2025-06-05 00:19:10 -0700
committerchrislu <chris.lu@gmail.com>2025-06-05 00:19:10 -0700
commit35f0daa198cfe1f1e05965f677fa4cf9153716d5 (patch)
tree6c4ee4dff39b303983448a3f70a23351aab12557
parent2f3de5e199cc529ac440f85cc2785dcb79a1cf56 (diff)
downloadseaweedfs-35f0daa198cfe1f1e05965f677fa4cf9153716d5.tar.xz
seaweedfs-35f0daa198cfe1f1e05965f677fa4cf9153716d5.zip
the isFsync parameter is essentially IsAsyncWrite and it needs to be turned off if s.isStopping
https://github.com/seaweedfs/seaweedfs/commit/d8c574a5ef1a811f9a0d447097d9edfcc0c1d84c#r159132764
-rw-r--r--weed/storage/store.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/weed/storage/store.go b/weed/storage/store.go
index 2b244cf70..9bfcae7ba 100644
--- a/weed/storage/store.go
+++ b/weed/storage/store.go
@@ -441,7 +441,7 @@ func (s *Store) WriteVolumeNeedle(i needle.VolumeId, n *needle.Needle, checkCook
err = fmt.Errorf("volume %d is read only", i)
return
}
- _, _, isUnchanged, err = v.writeNeedle2(n, checkCookie, fsync || s.isStopping)
+ _, _, isUnchanged, err = v.writeNeedle2(n, checkCookie, fsync && !s.isStopping)
return
}
glog.V(0).Infoln("volume", i, "not found!")