aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Lu <chris.lu@gmail.com>2020-02-11 09:45:02 -0800
committerChris Lu <chris.lu@gmail.com>2020-02-11 09:45:02 -0800
commit2a6db0fd436a62afdadbb03d55e8acd51d67791a (patch)
treea23603d55c2fd73c8dbf3022e2ac92c9dc41cc21
parent33b3bd467cfa222a910d0298bf3e2a77428ce843 (diff)
downloadseaweedfs-2a6db0fd436a62afdadbb03d55e8acd51d67791a.tar.xz
seaweedfs-2a6db0fd436a62afdadbb03d55e8acd51d67791a.zip
volume: return 204 for unchanged file uploads
fix https://github.com/chrislusf/seaweedfs/issues/1196
-rw-r--r--weed/server/volume_server_handlers_write.go5
1 files changed, 3 insertions, 2 deletions
diff --git a/weed/server/volume_server_handlers_write.go b/weed/server/volume_server_handlers_write.go
index cd35255e5..ac8fa4f42 100644
--- a/weed/server/volume_server_handlers_write.go
+++ b/weed/server/volume_server_handlers_write.go
@@ -52,9 +52,10 @@ func (vs *VolumeServer) PostHandler(w http.ResponseWriter, r *http.Request) {
ret := operation.UploadResult{}
_, isUnchanged, writeError := topology.ReplicatedWrite(vs.GetMaster(), vs.store, volumeId, needle, r)
- // http 304 status code does not allow body
+ // http 204 status code does not allow body
if writeError == nil && isUnchanged {
- w.WriteHeader(http.StatusNotModified)
+ setEtag(w, needle.Etag())
+ w.WriteHeader(http.StatusNoContent)
return
}