aboutsummaryrefslogtreecommitdiff
path: root/weed/filer
diff options
context:
space:
mode:
authorKonstantin Lebedev <lebedev_k@tochka.com>2021-03-16 14:15:17 +0500
committerKonstantin Lebedev <lebedev_k@tochka.com>2021-03-16 14:15:17 +0500
commit06da02739d4a97dd8288f7fa05de7cd369e97d78 (patch)
treed64b7f7780f7a1caa5a41f94131200f7c57bdb27 /weed/filer
parent3a3699867b0f6f6c12d4b6c3e127ee3c49b57a42 (diff)
downloadseaweedfs-06da02739d4a97dd8288f7fa05de7cd369e97d78.tar.xz
seaweedfs-06da02739d4a97dd8288f7fa05de7cd369e97d78.zip
CheckAllChunkViews() for HEAD requests only
Diffstat (limited to 'weed/filer')
-rw-r--r--weed/filer/filer_on_meta_event.go2
-rw-r--r--weed/filer/read_write.go2
-rw-r--r--weed/filer/stream.go23
3 files changed, 14 insertions, 13 deletions
diff --git a/weed/filer/filer_on_meta_event.go b/weed/filer/filer_on_meta_event.go
index c9f75a5ca..a91faeb24 100644
--- a/weed/filer/filer_on_meta_event.go
+++ b/weed/filer/filer_on_meta_event.go
@@ -52,7 +52,7 @@ func (f *Filer) maybeReloadFilerConfiguration(event *filer_pb.SubscribeMetadataR
func (f *Filer) readEntry(chunks []*filer_pb.FileChunk) ([]byte, error) {
var buf bytes.Buffer
- err := StreamContent(f.MasterClient, &buf, chunks, 0, math.MaxInt64)
+ err := StreamContent(f.MasterClient, &buf, chunks, 0, math.MaxInt64, false)
if err != nil {
return nil, err
}
diff --git a/weed/filer/read_write.go b/weed/filer/read_write.go
index 7a6da3beb..1a04c6503 100644
--- a/weed/filer/read_write.go
+++ b/weed/filer/read_write.go
@@ -27,7 +27,7 @@ func ReadEntry(masterClient *wdclient.MasterClient, filerClient filer_pb.Seaweed
return err
}
- return StreamContent(masterClient, byteBuffer, respLookupEntry.Entry.Chunks, 0, math.MaxInt64)
+ return StreamContent(masterClient, byteBuffer, respLookupEntry.Entry.Chunks, 0, math.MaxInt64, false)
}
diff --git a/weed/filer/stream.go b/weed/filer/stream.go
index 4353b1f07..f53563aa2 100644
--- a/weed/filer/stream.go
+++ b/weed/filer/stream.go
@@ -14,7 +14,7 @@ import (
"github.com/chrislusf/seaweedfs/weed/wdclient"
)
-func StreamContent(masterClient wdclient.HasLookupFileIdFunction, w io.Writer, chunks []*filer_pb.FileChunk, offset int64, size int64) error {
+func StreamContent(masterClient wdclient.HasLookupFileIdFunction, w io.Writer, chunks []*filer_pb.FileChunk, offset int64, size int64, isCheck bool) error {
glog.V(9).Infof("start to stream content for chunks: %+v\n", chunks)
chunkViews := ViewFromChunks(masterClient.GetLookupFileIdFunction(), chunks, offset, size)
@@ -34,15 +34,20 @@ func StreamContent(masterClient wdclient.HasLookupFileIdFunction, w io.Writer, c
fileId2Url[chunkView.FileId] = urlStrings
}
- for idx, chunkView := range chunkViews {
-
- urlStrings := fileId2Url[chunkView.FileId]
-
+ if isCheck {
// Pre-check all chunkViews urls
gErr := new(errgroup.Group)
- if len(chunkViews) > 1 && idx == 0 {
- CheckAllChunkViews(chunkViews[1:], &fileId2Url, gErr)
+ CheckAllChunkViews(chunkViews, &fileId2Url, gErr)
+ if err := gErr.Wait(); err != nil {
+ glog.Errorf("check all chunks: %v", err)
+ return fmt.Errorf("check all chunks: %v", err)
}
+ return nil
+ }
+
+ for _, chunkView := range chunkViews {
+
+ urlStrings := fileId2Url[chunkView.FileId]
data, err := retriedFetchChunkData(
urlStrings,
chunkView.CipherKey,
@@ -56,10 +61,6 @@ func StreamContent(masterClient wdclient.HasLookupFileIdFunction, w io.Writer, c
glog.Errorf("read chunk: %v", err)
return fmt.Errorf("read chunk: %v", err)
}
- if err := gErr.Wait(); err != nil {
- glog.Errorf("check all chunks: %v", err)
- return fmt.Errorf("check all chunks: %v", err)
- }
_, err = w.Write(data)
if err != nil {
glog.Errorf("write chunk: %v", err)