aboutsummaryrefslogtreecommitdiff
path: root/weed/filer
diff options
context:
space:
mode:
authorChris Lu <chris.lu@gmail.com>2021-05-05 15:11:39 -0700
committerChris Lu <chris.lu@gmail.com>2021-05-05 15:11:39 -0700
commitac71117ee67b0506ecf9fab382d6110e30c50e35 (patch)
treec1c79893492f4fb1120e582f40e5779a3761cf24 /weed/filer
parent24efa31e49aea0ff5e0cbdaa1a8cb6267dbcbfed (diff)
downloadseaweedfs-ac71117ee67b0506ecf9fab382d6110e30c50e35.tar.xz
seaweedfs-ac71117ee67b0506ecf9fab382d6110e30c50e35.zip
revert PR #1903 avoid http error: superfluous response.WriteHeader
Diffstat (limited to 'weed/filer')
-rw-r--r--weed/filer/filer_on_meta_event.go2
-rw-r--r--weed/filer/read_write.go2
-rw-r--r--weed/filer/stream.go25
3 files changed, 3 insertions, 26 deletions
diff --git a/weed/filer/filer_on_meta_event.go b/weed/filer/filer_on_meta_event.go
index a91faeb24..c9f75a5ca 100644
--- a/weed/filer/filer_on_meta_event.go
+++ b/weed/filer/filer_on_meta_event.go
@@ -52,7 +52,7 @@ func (f *Filer) maybeReloadFilerConfiguration(event *filer_pb.SubscribeMetadataR
func (f *Filer) readEntry(chunks []*filer_pb.FileChunk) ([]byte, error) {
var buf bytes.Buffer
- err := StreamContent(f.MasterClient, &buf, chunks, 0, math.MaxInt64, false)
+ err := StreamContent(f.MasterClient, &buf, chunks, 0, math.MaxInt64)
if err != nil {
return nil, err
}
diff --git a/weed/filer/read_write.go b/weed/filer/read_write.go
index d92d526d5..c4c90fb63 100644
--- a/weed/filer/read_write.go
+++ b/weed/filer/read_write.go
@@ -27,7 +27,7 @@ func ReadEntry(masterClient *wdclient.MasterClient, filerClient filer_pb.Seaweed
return err
}
- return StreamContent(masterClient, byteBuffer, respLookupEntry.Entry.Chunks, 0, math.MaxInt64, false)
+ return StreamContent(masterClient, byteBuffer, respLookupEntry.Entry.Chunks, 0, math.MaxInt64)
}
diff --git a/weed/filer/stream.go b/weed/filer/stream.go
index 661a210ea..f9a762187 100644
--- a/weed/filer/stream.go
+++ b/weed/filer/stream.go
@@ -3,7 +3,6 @@ package filer
import (
"bytes"
"fmt"
- "golang.org/x/sync/errgroup"
"io"
"math"
"strings"
@@ -14,7 +13,7 @@ import (
"github.com/chrislusf/seaweedfs/weed/wdclient"
)
-func StreamContent(masterClient wdclient.HasLookupFileIdFunction, w io.Writer, chunks []*filer_pb.FileChunk, offset int64, size int64, isCheck bool) error {
+func StreamContent(masterClient wdclient.HasLookupFileIdFunction, w io.Writer, chunks []*filer_pb.FileChunk, offset int64, size int64) error {
glog.V(9).Infof("start to stream content for chunks: %+v\n", chunks)
chunkViews := ViewFromChunks(masterClient.GetLookupFileIdFunction(), chunks, offset, size)
@@ -34,16 +33,6 @@ func StreamContent(masterClient wdclient.HasLookupFileIdFunction, w io.Writer, c
fileId2Url[chunkView.FileId] = urlStrings
}
- if isCheck {
- // Pre-check all chunkViews urls
- gErr := new(errgroup.Group)
- CheckAllChunkViews(chunkViews, &fileId2Url, gErr)
- if err := gErr.Wait(); err != nil {
- glog.Errorf("check all chunks: %v", err)
- return fmt.Errorf("check all chunks: %v", err)
- }
- return nil
- }
for _, chunkView := range chunkViews {
@@ -53,7 +42,6 @@ func StreamContent(masterClient wdclient.HasLookupFileIdFunction, w io.Writer, c
glog.Errorf("read chunk: %v", err)
return fmt.Errorf("read chunk: %v", err)
}
-
_, err = w.Write(data)
if err != nil {
glog.Errorf("write chunk: %v", err)
@@ -65,17 +53,6 @@ func StreamContent(masterClient wdclient.HasLookupFileIdFunction, w io.Writer, c
}
-func CheckAllChunkViews(chunkViews []*ChunkView, fileId2Url *map[string][]string, gErr *errgroup.Group) {
- for _, chunkView := range chunkViews {
- urlStrings := (*fileId2Url)[chunkView.FileId]
- glog.V(9).Infof("Check chunk: %+v\n url: %v", chunkView, urlStrings)
- gErr.Go(func() error {
- _, err := retriedFetchChunkData(urlStrings, chunkView.CipherKey, chunkView.IsGzipped, chunkView.IsFullChunk(), chunkView.Offset, int(chunkView.Size))
- return err
- })
- }
-}
-
// ---------------- ReadAllReader ----------------------------------
func ReadAll(masterClient *wdclient.MasterClient, chunks []*filer_pb.FileChunk) ([]byte, error) {