diff options
| author | Chris Lu <chris.lu@gmail.com> | 2020-11-02 14:20:38 -0800 |
|---|---|---|
| committer | Chris Lu <chris.lu@gmail.com> | 2020-11-02 14:20:38 -0800 |
| commit | a9662d44ace94d191a90cc0893021db2f172f902 (patch) | |
| tree | 4910a4e05e42910d8d9b3574b5f53514ac062615 /weed/filesys/filehandle.go | |
| parent | e0fcab47c00bbebf2352000bc8f8a9a2e30c076f (diff) | |
| download | seaweedfs-a9662d44ace94d191a90cc0893021db2f172f902.tar.xz seaweedfs-a9662d44ace94d191a90cc0893021db2f172f902.zip | |
avoid closing chunkSaveErrChan too early
Diffstat (limited to 'weed/filesys/filehandle.go')
| -rw-r--r-- | weed/filesys/filehandle.go | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/weed/filesys/filehandle.go b/weed/filesys/filehandle.go index 54bde3494..1fbeeb4dc 100644 --- a/weed/filesys/filehandle.go +++ b/weed/filesys/filehandle.go @@ -183,17 +183,20 @@ func (fh *FileHandle) Release(ctx context.Context, req *fuse.ReleaseRequest) err } if fh.f.isOpen == 0 { + if err := fh.doFlush(ctx, req.Header); err != nil { glog.Errorf("Release doFlush %s: %v", fh.f.Name, err) } + + // stop the goroutine + if !fh.dirtyPages.chunkSaveErrChanClosed { + fh.dirtyPages.chunkSaveErrChanClosed = true + close(fh.dirtyPages.chunkSaveErrChan) + } + fh.f.wfs.ReleaseHandle(fh.f.fullpath(), fuse.HandleID(fh.handle)) } - // stop the goroutine - if !fh.dirtyPages.chunkSaveErrChanClosed { - fh.dirtyPages.chunkSaveErrChanClosed = true - close(fh.dirtyPages.chunkSaveErrChan) - } return nil } |