diff options
| author | Chris Lu <chrislusf@users.noreply.github.com> | 2025-12-07 19:56:05 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-12-07 19:56:05 -0800 |
| commit | a9b3be416bb9deae3eecdbabef0ca3d4f8a11feb (patch) | |
| tree | 9136cd5ce06b95481f6c911c0cd44f378c4fe737 /weed/s3api/s3api_bucket_handlers.go | |
| parent | 5d53edb93b8e955905209570d1132e06c8ccd6e0 (diff) | |
| download | seaweedfs-a9b3be416bb9deae3eecdbabef0ca3d4f8a11feb.tar.xz seaweedfs-a9b3be416bb9deae3eecdbabef0ca3d4f8a11feb.zip | |
fix: initialize missing S3 options in filer to prevent nil pointer dereference (#7646)
* fix: initialize missing S3 options in filer to prevent nil pointer dereference
Fixes #7644
When starting the S3 gateway from the filer, several S3Options fields
were not being initialized, which could cause nil pointer dereferences
during startup.
This commit adds initialization for:
- iamConfig: for advanced IAM configuration
- metricsHttpPort: for Prometheus metrics endpoint
- metricsHttpIp: for binding the metrics endpoint
Also ensures metricsHttpIp defaults to bindIp when not explicitly set,
matching the behavior of the standalone S3 server.
This prevents the panic that was occurring in the s3.go:226 area when
these pointer fields were accessed but never initialized.
* fix: copy value instead of pointer for metricsHttpIp default
Address review comment to avoid pointer aliasing. Copy the value
instead of the pointer to prevent unexpected side effects if the
bindIp value is modified later.
Diffstat (limited to 'weed/s3api/s3api_bucket_handlers.go')
0 files changed, 0 insertions, 0 deletions
