diff options
| author | chrislu <chris.lu@gmail.com> | 2025-07-18 15:45:15 -0700 |
|---|---|---|
| committer | chrislu <chris.lu@gmail.com> | 2025-07-18 15:45:15 -0700 |
| commit | 9f88fd2ea5ca08e430d22d3335f4c96acfa665e4 (patch) | |
| tree | a2c02b289dfa79183dbd41dd83f6561a9000ac10 /weed/s3api/s3api_object_retention.go | |
| parent | 0123abe49b51a250b46831e07417f5f5ae503866 (diff) | |
| download | seaweedfs-9f88fd2ea5ca08e430d22d3335f4c96acfa665e4.tar.xz seaweedfs-9f88fd2ea5ca08e430d22d3335f4c96acfa665e4.zip | |
fixes
With these comprehensive fixes, the s3-tests should now:
✅ Return InvalidBucketState (409 Conflict) for object lock operations on invalid buckets
✅ Return InvalidRetentionPeriod for invalid retention periods
✅ Return MalformedXML for malformed retention configurations
✅ Include VersionId in response headers when available
✅ Return proper HTTP status codes for all error conditions
✅ Handle all object lock validation errors consistently
The workflow should now pass significantly more object lock tests, bringing SeaweedFS's S3 object lock implementation much closer to AWS S3 compatibility standards.
Diffstat (limited to 'weed/s3api/s3api_object_retention.go')
| -rw-r--r-- | weed/s3api/s3api_object_retention.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/weed/s3api/s3api_object_retention.go b/weed/s3api/s3api_object_retention.go index 87d780228..5d4f846ab 100644 --- a/weed/s3api/s3api_object_retention.go +++ b/weed/s3api/s3api_object_retention.go @@ -656,9 +656,9 @@ func (s3a *S3ApiServer) handleObjectLockAvailabilityCheck(w http.ResponseWriter, if errors.Is(err, ErrBucketNotFound) { s3err.WriteErrorResponse(w, request, s3err.ErrNoSuchBucket) } else { - // Return 409 Conflict for object lock operations on buckets without object lock enabled + // Return InvalidBucketState for object lock operations on buckets without object lock enabled // This matches AWS S3 behavior and s3-tests expectations - s3err.WriteErrorResponse(w, request, s3err.ErrBucketNotEmpty) // This maps to 409 Conflict + s3err.WriteErrorResponse(w, request, s3err.ErrInvalidBucketState) } return false } |
