1 files changed, 85 insertions, 52 deletions

diff --git a/weed/filesys/file.go b/weed/filesys/file.go
index 2d4be3c80..4ac8b732d 100644
--- a/weed/filesys/file.go
+++ b/weed/filesys/file.go
@@ -20,6 +20,10 @@ var _ = fs.Node(&File{})
 var _ = fs.NodeOpener(&File{})
 var _ = fs.NodeFsyncer(&File{})
 var _ = fs.NodeSetattrer(&File{})
+var _ = fs.NodeGetxattrer(&File{})
+var _ = fs.NodeSetxattrer(&File{})
+var _ = fs.NodeRemovexattrer(&File{})
+var _ = fs.NodeListxattrer(&File{})
 
 type File struct {
 	Name           string
@@ -38,7 +42,7 @@ func (file *File) Attr(ctx context.Context, attr *fuse.Attr) error {
 
 	glog.V(4).Infof("file Attr %s", file.fullpath())
 
-	if err := file.maybeLoadAttributes(ctx); err != nil {
+	if err := file.maybeLoadEntry(ctx); err != nil {
 		return err
 	}
 
@@ -54,6 +58,17 @@ func (file *File) Attr(ctx context.Context, attr *fuse.Attr) error {
 
 }
 
+func (file *File) Getxattr(ctx context.Context, req *fuse.GetxattrRequest, resp *fuse.GetxattrResponse) error {
+
+	glog.V(4).Infof("file Getxattr %s", file.fullpath())
+
+	if err := file.maybeLoadEntry(ctx); err != nil {
+		return err
+	}
+
+	return getxattr(file.entry, req, resp)
+}
+
 func (file *File) Open(ctx context.Context, req *fuse.OpenRequest, resp *fuse.OpenResponse) (fs.Handle, error) {
 
 	glog.V(4).Infof("file %v open %+v", file.fullpath(), req)
@@ -72,7 +87,7 @@ func (file *File) Open(ctx context.Context, req *fuse.OpenRequest, resp *fuse.Op
 
 func (file *File) Setattr(ctx context.Context, req *fuse.SetattrRequest, resp *fuse.SetattrResponse) error {
 
-	if err := file.maybeLoadAttributes(ctx); err != nil {
+	if err := file.maybeLoadEntry(ctx); err != nil {
 		return err
 	}
 
@@ -113,75 +128,74 @@ func (file *File) Setattr(ctx context.Context, req *fuse.SetattrRequest, resp *f
 
 	file.wfs.listDirectoryEntriesCache.Delete(file.fullpath())
 
-	return file.wfs.WithFilerClient(ctx, func(client filer_pb.SeaweedFilerClient) error {
+	return file.saveEntry(ctx)
 
-		request := &filer_pb.UpdateEntryRequest{
-			Directory: file.dir.Path,
-			Entry:     file.entry,
-		}
+}
 
-		glog.V(1).Infof("set attr file entry: %v", request)
-		_, err := client.UpdateEntry(ctx, request)
-		if err != nil {
-			glog.V(0).Infof("UpdateEntry file %s/%s: %v", file.dir.Path, file.Name, err)
-			return fuse.EIO
-		}
+func (file *File) Setxattr(ctx context.Context, req *fuse.SetxattrRequest) error {
 
-		return nil
-	})
+	glog.V(4).Infof("file Setxattr %s: %s", file.fullpath(), req.Name)
 
-}
+	if err := file.maybeLoadEntry(ctx); err != nil {
+		return err
+	}
 
-func (file *File) Fsync(ctx context.Context, req *fuse.FsyncRequest) error {
-	// fsync works at OS level
-	// write the file chunks to the filerGrpcAddress
-	glog.V(3).Infof("%s/%s fsync file %+v", file.dir.Path, file.Name, req)
+	if err := setxattr(file.entry, req); err != nil {
+		return err
+	}
+
+	return file.saveEntry(ctx)
 
-	return nil
 }
 
-func (file *File) maybeLoadAttributes(ctx context.Context) error {
-	if file.entry == nil || !file.isOpen {
-		item := file.wfs.listDirectoryEntriesCache.Get(file.fullpath())
-		var entry *filer_pb.Entry
-		if item != nil && !item.Expired() {
-			entry = item.Value().(*filer_pb.Entry)
-		}
-		if entry != nil {
+func (file *File) Removexattr(ctx context.Context, req *fuse.RemovexattrRequest) error {
 
-			glog.V(4).Infof("file read attr cache hit %s", file.fullpath())
+	glog.V(4).Infof("file Removexattr %s: %s", file.fullpath(), req.Name)
 
-			file.setEntry(entry)
-			// glog.V(1).Infof("file attr read cached %v attributes", file.Name)
-		} else {
+	if err := file.maybeLoadEntry(ctx); err != nil {
+		return err
+	}
+
+	if err := removexattr(file.entry, req); err != nil {
+		return err
+	}
 
-			glog.V(3).Infof("file read attr cache miss %s", file.fullpath())
+	return file.saveEntry(ctx)
 
-			err := file.wfs.WithFilerClient(ctx, func(client filer_pb.SeaweedFilerClient) error {
+}
 
-				request := &filer_pb.LookupDirectoryEntryRequest{
-					Name:      file.Name,
-					Directory: file.dir.Path,
-				}
+func (file *File) Listxattr(ctx context.Context, req *fuse.ListxattrRequest, resp *fuse.ListxattrResponse) error {
 
-				resp, err := client.LookupDirectoryEntry(ctx, request)
-				if err != nil {
-					glog.V(3).Infof("file attr read file %v: %v", request, err)
-					return fuse.ENOENT
-				}
+	glog.V(4).Infof("file Listxattr %s: %s", file.fullpath())
 
-				file.setEntry(resp.Entry)
+	if err := file.maybeLoadEntry(ctx); err != nil {
+		return err
+	}
 
-				glog.V(3).Infof("file attr %v %+v: %d", file.fullpath(), file.entry.Attributes, filer2.TotalSize(file.entry.Chunks))
+	if err := listxattr(file.entry, req, resp); err != nil {
+		return err
+	}
 
-				// file.wfs.listDirectoryEntriesCache.Set(file.fullpath(), file.entry, file.wfs.option.EntryCacheTtl)
+	return file.saveEntry(ctx)
 
-				return nil
-			})
+}
 
-			if err != nil {
-				return err
-			}
+func (file *File) Fsync(ctx context.Context, req *fuse.FsyncRequest) error {
+	// fsync works at OS level
+	// write the file chunks to the filerGrpcAddress
+	glog.V(3).Infof("%s/%s fsync file %+v", file.dir.Path, file.Name, req)
+
+	return nil
+}
+
+func (file *File) maybeLoadEntry(ctx context.Context) error {
+	if file.entry == nil || !file.isOpen {
+		entry, err := file.wfs.maybeLoadEntry(ctx, file.dir.Path, file.Name)
+		if err != nil {
+			return err
+		}
+		if entry != nil {
+			file.setEntry(entry)
 		}
 	}
 	return nil
@@ -216,3 +230,22 @@ func (file *File) setEntry(entry *filer_pb.Entry) {
 	file.entry = entry
 	file.entryViewCache = filer2.NonOverlappingVisibleIntervals(file.entry.Chunks)
 }
+
+func (file *File) saveEntry(ctx context.Context) error {
+	return file.wfs.WithFilerClient(ctx, func(client filer_pb.SeaweedFilerClient) error {
+
+		request := &filer_pb.UpdateEntryRequest{
+			Directory: file.dir.Path,
+			Entry:     file.entry,
+		}
+
+		glog.V(1).Infof("save file entry: %v", request)
+		_, err := client.UpdateEntry(ctx, request)
+		if err != nil {
+			glog.V(0).Infof("UpdateEntry file %s/%s: %v", file.dir.Path, file.Name, err)
+			return fuse.EIO
+		}
+
+		return nil
+	})
+}