aboutsummaryrefslogtreecommitdiff
path: root/weed/server/volume_server_handlers.go
diff options
context:
space:
mode:
Diffstat (limited to 'weed/server/volume_server_handlers.go')
-rw-r--r--weed/server/volume_server_handlers.go28
1 files changed, 20 insertions, 8 deletions
diff --git a/weed/server/volume_server_handlers.go b/weed/server/volume_server_handlers.go
index c199fa46a..aa231e650 100644
--- a/weed/server/volume_server_handlers.go
+++ b/weed/server/volume_server_handlers.go
@@ -1,10 +1,12 @@
package weed_server
import (
+ "fmt"
"net/http"
"strconv"
"strings"
"sync/atomic"
+ "time"
"github.com/chrislusf/seaweedfs/weed/util"
@@ -55,22 +57,32 @@ func (vs *VolumeServer) privateStoreHandler(w http.ResponseWriter, r *http.Reque
vs.guard.WhiteList(vs.DeleteHandler)(w, r)
case "PUT", "POST":
- // wait until in flight data is less than the limit
contentLength := getContentLength(r)
-
+ startTime := time.Now()
+ vs.inFlightUploadDataLimitCond.L.Lock()
// exclude the replication from the concurrentUploadLimitMB
- if r.URL.Query().Get("type") != "replicate" { //Non-Replication
- vs.inFlightUploadDataLimitCond.L.Lock()
- for vs.concurrentUploadLimit != 0 && atomic.LoadInt64(&vs.inFlightUploadDataSize) > vs.concurrentUploadLimit {
+ if r.URL.Query().Get("type") != "replicate" {
+ for vs.concurrentUploadLimit != 0 && vs.inFlightUploadDataSize > vs.concurrentUploadLimit {
+ //wait timeout
+ if startTime.Add(vs.inflightUploadDataTimeout).Before(time.Now()) {
+ err := fmt.Errorf("reject because inflight upload data %d > %d, and wait timeout", vs.inFlightUploadDataSize, vs.concurrentUploadLimit)
+ vs.inFlightUploadDataLimitCond.L.Unlock()
+ glog.V(1).Infof("too many requests: %v", err)
+ writeJsonError(w, r, http.StatusTooManyRequests, err)
+ return
+ }
+
glog.V(4).Infof("wait because inflight upload data %d > %d", vs.inFlightUploadDataSize, vs.concurrentUploadLimit)
vs.inFlightUploadDataLimitCond.Wait()
}
- vs.inFlightUploadDataLimitCond.L.Unlock()
}
+ vs.inFlightUploadDataSize += contentLength
+ vs.inFlightUploadDataLimitCond.L.Unlock()
- atomic.AddInt64(&vs.inFlightUploadDataSize, contentLength)
defer func() {
- atomic.AddInt64(&vs.inFlightUploadDataSize, -contentLength)
+ vs.inFlightUploadDataLimitCond.L.Lock()
+ vs.inFlightUploadDataSize -= contentLength
+ vs.inFlightUploadDataLimitCond.L.Unlock()
vs.inFlightUploadDataLimitCond.Signal()
}()