diff options
| author | chrislusf <chris.lu@gmail.com> | 2025-12-06 12:17:14 -0800 |
|---|---|---|
| committer | Chris Lu <chrislusf@users.noreply.github.com> | 2025-12-06 18:53:22 -0800 |
| commit | 5091b184a6af51728e939b938a0b42845960ebc5 (patch) | |
| tree | 499956f3391d1a1cfb95b405b0fcc70183b70b13 /.github/workflows | |
| parent | dd5d682b1fdf9be8f30d39f2211c6cb0a7ef7c2f (diff) | |
| download | seaweedfs-csi-driver-5091b184a6af51728e939b938a0b42845960ebc5.tar.xz seaweedfs-csi-driver-5091b184a6af51728e939b938a0b42845960ebc5.zip | |
fix: improve integration test reliability and make mount service opt-in
- Add hard failure if SeaweedFS filer never becomes ready (exit 1 after loop)
- Remove || true from CSI pod readiness checks for earlier failure detection
- Change mountService.enabled default to false (opt-in) for safer upgrades
Existing installations won't unexpectedly get a new privileged DaemonSet
Diffstat (limited to '.github/workflows')
| -rw-r--r-- | .github/workflows/integration_test.yaml | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/.github/workflows/integration_test.yaml b/.github/workflows/integration_test.yaml index bdd11a2..be9b78b 100644 --- a/.github/workflows/integration_test.yaml +++ b/.github/workflows/integration_test.yaml @@ -116,11 +116,13 @@ jobs: for i in {1..30}; do if kubectl exec -n seaweedfs deploy/seaweedfs -- wget -q -O- http://localhost:8888/; then echo "SeaweedFS filer is ready" - break + exit 0 fi echo "Waiting for filer... ($i/30)" sleep 2 done + echo "SeaweedFS filer did not become ready in time" + exit 1 - name: Deploy CSI Driver run: | @@ -132,11 +134,11 @@ jobs: sed 's|SEAWEEDFS_FILER:8888|seaweedfs.seaweedfs.svc.cluster.local:8888|g' | \ kubectl apply -f - - # Wait for CSI driver pods to be ready + # Wait for CSI driver pods to be ready (fail fast if they don't start) sleep 15 - kubectl wait --for=condition=ready pod -l app=seaweedfs-controller --timeout=120s || true - kubectl wait --for=condition=ready pod -l app=seaweedfs-node --timeout=120s || true - kubectl wait --for=condition=ready pod -l app=seaweedfs-mount --timeout=120s || true + kubectl wait --for=condition=ready pod -l app=seaweedfs-controller --timeout=120s + kubectl wait --for=condition=ready pod -l app=seaweedfs-node --timeout=120s + kubectl wait --for=condition=ready pod -l app=seaweedfs-mount --timeout=120s kubectl get pods -l 'app in (seaweedfs-controller,seaweedfs-node,seaweedfs-mount)' - name: Create StorageClass and test PVC |