aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorn9 <n9>2023-08-10 11:10:56 +0200
committerChris Lu <chrislusf@users.noreply.github.com>2023-08-10 06:51:06 -0700
commit609101d970f2243df169585967d237bac6d8f9a0 (patch)
tree947158b0a5b16203eb32ba0c2cad8f586b682a9e
parent32560a9f185c8fb6fa8926781041b6c718c1720f (diff)
downloadseaweedfs-csi-driver-609101d970f2243df169585967d237bac6d8f9a0.tar.xz
seaweedfs-csi-driver-609101d970f2243df169585967d237bac6d8f9a0.zip
Fix: error strings should not be capitalized (ST1005)
Context: https://github.com/golang/go/wiki/CodeReviewComments#error-strings https://stackoverflow.com/a/68793833
-rw-r--r--pkg/driver/controllerserver.go6
-rw-r--r--pkg/driver/mount_util.go2
-rw-r--r--pkg/driver/mounter.go2
-rw-r--r--pkg/driver/utils.go2
4 files changed, 6 insertions, 6 deletions
diff --git a/pkg/driver/controllerserver.go b/pkg/driver/controllerserver.go
index 57b43d0..0d8b671 100644
--- a/pkg/driver/controllerserver.go
+++ b/pkg/driver/controllerserver.go
@@ -54,7 +54,7 @@ func (cs *ControllerServer) CreateVolume(ctx context.Context, req *csi.CreateVol
}
if err := filer_pb.Mkdir(cs.Driver, "/buckets", volumeId, nil); err != nil {
- return nil, fmt.Errorf("Error setting bucket metadata: %v", err)
+ return nil, fmt.Errorf("error setting bucket metadata: %v", err)
}
glog.V(4).Infof("volume created %s", volumeId)
@@ -85,7 +85,7 @@ func (cs *ControllerServer) DeleteVolume(ctx context.Context, req *csi.DeleteVol
glog.V(4).Infof("deleting volume %s", volumeId)
if err := filer_pb.Remove(cs.Driver, "/buckets", volumeId, true, true, true, false, nil); err != nil {
- return nil, fmt.Errorf("Error setting bucket metadata: %v", err)
+ return nil, fmt.Errorf("error setting bucket metadata: %v", err)
}
return &csi.DeleteVolumeResponse{}, nil
@@ -137,7 +137,7 @@ func (cs *ControllerServer) ValidateVolumeCapabilities(ctx context.Context, req
exists, err := filer_pb.Exists(cs.Driver, "/buckets", req.GetVolumeId(), true)
if err != nil {
- return nil, fmt.Errorf("Error checking bucket %s exists: %v", req.GetVolumeId(), err)
+ return nil, fmt.Errorf("error checking bucket %s exists: %v", req.GetVolumeId(), err)
}
if !exists {
// return an error if the volume requested does not exist
diff --git a/pkg/driver/mount_util.go b/pkg/driver/mount_util.go
index 40716d0..b62a9e7 100644
--- a/pkg/driver/mount_util.go
+++ b/pkg/driver/mount_util.go
@@ -23,7 +23,7 @@ func waitForMount(path string, timeout time.Duration) error {
time.Sleep(interval)
elapsed = elapsed + interval
if elapsed >= timeout {
- return errors.New("Timeout waiting for mount")
+ return errors.New("timeout waiting for mount")
}
}
}
diff --git a/pkg/driver/mounter.go b/pkg/driver/mounter.go
index 2e51314..756f671 100644
--- a/pkg/driver/mounter.go
+++ b/pkg/driver/mounter.go
@@ -59,7 +59,7 @@ func fuseMount(path string, command string, args []string) (Unmounter, error) {
err := cmd.Start()
if err != nil {
glog.Errorf("running weed mount: %v", err)
- return nil, fmt.Errorf("Error fuseMount command: %s\nargs: %s\nerror: %v", command, args, err)
+ return nil, fmt.Errorf("error fuseMount command: %s\nargs: %s\nerror: %v", command, args, err)
}
fu := &fuseUnmounter{
diff --git a/pkg/driver/utils.go b/pkg/driver/utils.go
index eee1825..24298bb 100644
--- a/pkg/driver/utils.go
+++ b/pkg/driver/utils.go
@@ -56,7 +56,7 @@ func ParseEndpoint(ep string) (string, string, error) {
return s[0], s[1], nil
}
}
- return "", "", fmt.Errorf("Invalid endpoint: %v", ep)
+ return "", "", fmt.Errorf("invalid endpoint: %v", ep)
}
func logGRPC(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (interface{}, error) {