diff options
| author | chrislusf <chris.lu@gmail.com> | 2025-12-05 18:44:43 -0800 |
|---|---|---|
| committer | Chris Lu <chrislusf@users.noreply.github.com> | 2025-12-06 18:53:22 -0800 |
| commit | f292fb147fb04f857596a0c7bd2ddfef788e52e2 (patch) | |
| tree | 46acc28e48c10bd9967b6147227e0b8f2c1791e2 /deploy/kubernetes | |
| parent | d9a69c414e5050183df1e3174553a931e8dae064 (diff) | |
| download | seaweedfs-csi-driver-f292fb147fb04f857596a0c7bd2ddfef788e52e2.tar.xz seaweedfs-csi-driver-f292fb147fb04f857596a0c7bd2ddfef788e52e2.zip | |
fix: address code review feedback
- CRITICAL: Make socket path configurable based on mountEndpoint
- Added volumeSocketDir field to SeaweedFsDriver
- LocalSocketPath now accepts baseDir parameter
- Derived from mountEndpoint for user-configurable socket paths
- HIGH: Pin seaweedfs version in Dockerfiles for reproducible builds
- Added SEAWEEDFS_VERSION build arg (default: 3.80)
- Clone specific tag instead of master
- HIGH: Fix Dockerfile.dev to use local context instead of personal fork
- Removed hardcoded zemul/seaweedfs-csi-driver clone
- Now uses COPY . . for local development
- HIGH: Change :latest to :dev in kubernetes manifests
- Mutable :latest tag replaced with :dev for predictability
- MEDIUM: Remove Aliyun mirror from Dockerfile.dev
- Region-specific mirrors shouldn't be in general-purpose files
- MEDIUM: Improve error handling in client.go
- Now reports read errors when failing to read error response body
- MEDIUM: Fix inconsistent error return in manager.go
- Return nil instead of empty struct on error (Go idiom)
Diffstat (limited to 'deploy/kubernetes')
| -rw-r--r-- | deploy/kubernetes/seaweedfs-csi.yaml | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/deploy/kubernetes/seaweedfs-csi.yaml b/deploy/kubernetes/seaweedfs-csi.yaml index 2fc4f9b..9fb140b 100644 --- a/deploy/kubernetes/seaweedfs-csi.yaml +++ b/deploy/kubernetes/seaweedfs-csi.yaml @@ -216,7 +216,7 @@ spec: add: - SYS_ADMIN privileged: true - image: chrislusf/seaweedfs-csi-driver:latest + image: chrislusf/seaweedfs-csi-driver:dev imagePullPolicy: IfNotPresent args: - --endpoint=$(CSI_ENDPOINT) @@ -375,7 +375,7 @@ spec: add: - SYS_ADMIN privileged: true - image: chrislusf/seaweedfs-mount:latest + image: chrislusf/seaweedfs-mount:dev imagePullPolicy: IfNotPresent args: - --endpoint=$(MOUNT_ENDPOINT) @@ -444,7 +444,7 @@ spec: containers: # SeaweedFs Plugin (controller) - name: seaweedfs-csi-plugin - image: chrislusf/seaweedfs-csi-driver:latest + image: chrislusf/seaweedfs-csi-driver:dev imagePullPolicy: IfNotPresent args : - --endpoint=$(CSI_ENDPOINT) |