aboutsummaryrefslogtreecommitdiff
path: root/pkg/driver/driver.go
diff options
context:
space:
mode:
authorchrislusf <chris.lu@gmail.com>2025-12-06 12:21:55 -0800
committerchrislusf <chris.lu@gmail.com>2025-12-06 12:21:55 -0800
commit824524d567416c36bfafcbd7a06aa4ddd2114136 (patch)
tree8f0e4caf185d7923e6359d9ecaa57b467f4053f7 /pkg/driver/driver.go
parentb860f1436c890107161d090b8757ab3c3c25b24c (diff)
downloadseaweedfs-csi-driver-824524d567416c36bfafcbd7a06aa4ddd2114136.tar.xz
seaweedfs-csi-driver-824524d567416c36bfafcbd7a06aa4ddd2114136.zip
fix: address gemini review - OnDelete strategy and log invalid endpoint
- Change seaweedfs-mount DaemonSet updateStrategy from RollingUpdate to OnDelete in seaweedfs-csi.yaml for consistency with values.yaml (safer for active mounts) - Add warning log when invalid mountEndpoint is provided to aid debugging
Diffstat (limited to 'pkg/driver/driver.go')
-rw-r--r--pkg/driver/driver.go4
1 files changed, 3 insertions, 1 deletions
diff --git a/pkg/driver/driver.go b/pkg/driver/driver.go
index 6bdcc3b..84052ef 100644
--- a/pkg/driver/driver.go
+++ b/pkg/driver/driver.go
@@ -62,7 +62,9 @@ func NewSeaweedFsDriver(name, filer, nodeID, endpoint, mountEndpoint string, ena
volumeSocketDir := mountmanager.DefaultSocketDir
if mountEndpoint != "" {
_, address, err := mountmanager.ParseEndpoint(mountEndpoint)
- if err == nil && address != "" {
+ if err != nil {
+ glog.Warningf("invalid mount endpoint %q, using default socket directory %q: %v", mountEndpoint, volumeSocketDir, err)
+ } else if address != "" {
volumeSocketDir = filepath.Dir(address)
}
}