diff options
| author | chrislusf <chris.lu@gmail.com> | 2025-12-06 12:21:55 -0800 |
|---|---|---|
| committer | Chris Lu <chrislusf@users.noreply.github.com> | 2025-12-06 18:53:22 -0800 |
| commit | 96363f76727a96809a8641d5d2e9d991bcba0c04 (patch) | |
| tree | 8f0e4caf185d7923e6359d9ecaa57b467f4053f7 /pkg | |
| parent | 5091b184a6af51728e939b938a0b42845960ebc5 (diff) | |
| download | seaweedfs-csi-driver-96363f76727a96809a8641d5d2e9d991bcba0c04.tar.xz seaweedfs-csi-driver-96363f76727a96809a8641d5d2e9d991bcba0c04.zip | |
fix: address gemini review - OnDelete strategy and log invalid endpoint
- Change seaweedfs-mount DaemonSet updateStrategy from RollingUpdate to OnDelete
in seaweedfs-csi.yaml for consistency with values.yaml (safer for active mounts)
- Add warning log when invalid mountEndpoint is provided to aid debugging
Diffstat (limited to 'pkg')
| -rw-r--r-- | pkg/driver/driver.go | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/pkg/driver/driver.go b/pkg/driver/driver.go index 6bdcc3b..84052ef 100644 --- a/pkg/driver/driver.go +++ b/pkg/driver/driver.go @@ -62,7 +62,9 @@ func NewSeaweedFsDriver(name, filer, nodeID, endpoint, mountEndpoint string, ena volumeSocketDir := mountmanager.DefaultSocketDir if mountEndpoint != "" { _, address, err := mountmanager.ParseEndpoint(mountEndpoint) - if err == nil && address != "" { + if err != nil { + glog.Warningf("invalid mount endpoint %q, using default socket directory %q: %v", mountEndpoint, volumeSocketDir, err) + } else if address != "" { volumeSocketDir = filepath.Dir(address) } } |