| Age | Commit message (Collapse) | Author | Files | Lines |
|
- Log warning if stopping mount process fails after mount wait timeout
to help diagnose potential zombie processes
- Add comment explaining the 100ms delay before unmounting is for
FUSE cleanup and pending I/O to complete
|
|
- Change image tags from :dev to :latest in seaweedfs-csi.yaml for
predictable production deployments
- Replace deprecated IsMountPoint with IsLikelyNotMountPoint for
consistency with k8s.io/mount-utils recommendations
|
|
The weedMountProcess.wait() function already handles unmounting when the
process terminates. Removing the explicit unmount call in Unmount()
centralizes the unmount logic and avoids potential race conditions.
|
|
- Unmount now uses getMount first, only removes from state after all
cleanup operations succeed (transactional behavior)
- Add volume ID prefix to weed mount stdout/stderr logs for better
debugging when multiple mounts are active
|
|
- Change cacheDir permissions from 0750 to 0755 for non-root access
- Change targetPath (mount point) permissions from 0750 to 0755
- Remove ineffective os.ErrProcessDone checks (not exported in os package)
|
|
- Change mountService updateStrategy from RollingUpdate to OnDelete
(mount service not yet resilient to its own restarts)
- Change mountService image from :latest to :dev for consistency
- Fix defer os.RemoveAll: explicitly remove cache dir after process stops
to avoid removing while process might still be running
|
|
- Set localSocket in rebuildVolumeFromStaging to fix invalid gRPC target
- Use SHA256 hash (16 hex chars) in LocalSocketPath to minimize collision risk
- Update GitHub Actions to latest versions (checkout@v4, metadata-action@v5, etc.)
- Fix volumeMounts/volumes conditional mismatch in helm templates
- Add documentation for mountService defaults in values.yaml
|
|
directory exists
Address review feedback from gemini-code-assist:
- Replace recursive approach with non-recursive to avoid potential stack overflow
- Always call os.MkdirAll at the end to ensure directory exists after unmount
- Add better error messages with context
- Add logging for unmount operations
|
|
- CRITICAL: Make socket path configurable based on mountEndpoint
- Added volumeSocketDir field to SeaweedFsDriver
- LocalSocketPath now accepts baseDir parameter
- Derived from mountEndpoint for user-configurable socket paths
- HIGH: Pin seaweedfs version in Dockerfiles for reproducible builds
- Added SEAWEEDFS_VERSION build arg (default: 3.80)
- Clone specific tag instead of master
- HIGH: Fix Dockerfile.dev to use local context instead of personal fork
- Removed hardcoded zemul/seaweedfs-csi-driver clone
- Now uses COPY . . for local development
- HIGH: Change :latest to :dev in kubernetes manifests
- Mutable :latest tag replaced with :dev for predictability
- MEDIUM: Remove Aliyun mirror from Dockerfile.dev
- Region-specific mirrors shouldn't be in general-purpose files
- MEDIUM: Improve error handling in client.go
- Now reports read errors when failing to read error response body
- MEDIUM: Fix inconsistent error return in manager.go
- Return nil instead of empty struct on error (Go idiom)
|
|
|
|
|
|
|
|
|
|
the CSI components to call it.
|