diff options
| author | Lisandro Pin <lisandro.pin@proton.ch> | 2025-11-10 04:58:38 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-11-09 19:58:38 -0800 |
| commit | 76e4a519646a60c612956d197652359b1d4ba477 (patch) | |
| tree | 37de583f5f6e79936bc137afe6e6d4b12e6065a5 /weed/shell/command_ec_balance.go | |
| parent | 2a05af2e14741540cad00a410f8e851f863628c7 (diff) | |
| download | seaweedfs-76e4a519646a60c612956d197652359b1d4ba477.tar.xz seaweedfs-76e4a519646a60c612956d197652359b1d4ba477.zip | |
Unify the parameter to disable dry-run on weed shell commands to `-apply` (instead of `-force`). (#7450)
* Unify the parameter to disable dry-run on weed shell commands to --apply (instead of --force).
* lint
* refactor
* Execution Order Corrected
* handle deprecated force flag
* fix help messages
* Refactoring]: Using flag.FlagSet.Visit()
* consistent with other commands
* Checks for both flags
* fix toml files
---------
Co-authored-by: chrislu <chris.lu@gmail.com>
Diffstat (limited to 'weed/shell/command_ec_balance.go')
| -rw-r--r-- | weed/shell/command_ec_balance.go | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/weed/shell/command_ec_balance.go b/weed/shell/command_ec_balance.go index 96c59f9da..935348602 100644 --- a/weed/shell/command_ec_balance.go +++ b/weed/shell/command_ec_balance.go @@ -20,7 +20,7 @@ func (c *commandEcBalance) Name() string { func (c *commandEcBalance) Help() string { return `balance all ec shards among all racks and volume servers - ec.balance [-c EACH_COLLECTION|<collection_name>] [-force] [-dataCenter <data_center>] [-shardReplicaPlacement <replica_placement>] + ec.balance [-c EACH_COLLECTION|<collection_name>] [-apply] [-dataCenter <data_center>] [-shardReplicaPlacement <replica_placement>] Algorithm: ` + ecBalanceAlgorithmDescription @@ -36,11 +36,16 @@ func (c *commandEcBalance) Do(args []string, commandEnv *CommandEnv, writer io.W dc := balanceCommand.String("dataCenter", "", "only apply the balancing for this dataCenter") shardReplicaPlacement := balanceCommand.String("shardReplicaPlacement", "", "replica placement for EC shards, or master default if empty") maxParallelization := balanceCommand.Int("maxParallelization", DefaultMaxParallelization, "run up to X tasks in parallel, whenever possible") - applyBalancing := balanceCommand.Bool("force", false, "apply the balancing plan") + applyBalancing := balanceCommand.Bool("apply", false, "apply the balancing plan") + // TODO: remove this alias + applyBalancingAlias := balanceCommand.Bool("force", false, "apply the balancing plan (alias for -apply)") + if err = balanceCommand.Parse(args); err != nil { return nil } - infoAboutSimulationMode(writer, *applyBalancing, "-force") + + handleDeprecatedForceFlag(writer, balanceCommand, applyBalancingAlias, applyBalancing) + infoAboutSimulationMode(writer, *applyBalancing, "-apply") if err = commandEnv.confirmIsLocked(args); err != nil { return |