aboutsummaryrefslogtreecommitdiff
path: root/weed/shell/command_volume_configure_replication.go
diff options
context:
space:
mode:
authorChris Lu <chris.lu@gmail.com>2021-02-22 00:28:42 -0800
committerChris Lu <chris.lu@gmail.com>2021-02-22 00:28:42 -0800
commit1c233ad986bbbf5de3394c734a1bafebaf67b9e0 (patch)
treec212a72f5b2e9414d2ef6d9177d0c08f59f2f3f1 /weed/shell/command_volume_configure_replication.go
parent151c281f36f1523593ad2777fd66c347934d73fb (diff)
downloadseaweedfs-1c233ad986bbbf5de3394c734a1bafebaf67b9e0.tar.xz
seaweedfs-1c233ad986bbbf5de3394c734a1bafebaf67b9e0.zip
refactoring
Diffstat (limited to 'weed/shell/command_volume_configure_replication.go')
-rw-r--r--weed/shell/command_volume_configure_replication.go9
1 files changed, 3 insertions, 6 deletions
diff --git a/weed/shell/command_volume_configure_replication.go b/weed/shell/command_volume_configure_replication.go
index ecbe402e8..e3f034873 100644
--- a/weed/shell/command_volume_configure_replication.go
+++ b/weed/shell/command_volume_configure_replication.go
@@ -56,11 +56,8 @@ func (c *commandVolumeConfigureReplication) Do(args []string, commandEnv *Comman
}
replicaPlacementInt32 := uint32(replicaPlacement.Byte())
- var resp *master_pb.VolumeListResponse
- err = commandEnv.MasterClient.WithClient(func(client master_pb.SeaweedClient) error {
- resp, err = client.VolumeList(context.Background(), &master_pb.VolumeListRequest{})
- return err
- })
+ // collect topology information
+ topologyInfo, _, err := collectTopologyInfo(commandEnv)
if err != nil {
return err
}
@@ -69,7 +66,7 @@ func (c *commandVolumeConfigureReplication) Do(args []string, commandEnv *Comman
// find all data nodes with volumes that needs replication change
var allLocations []location
- eachDataNode(resp.TopologyInfo, func(dc string, rack RackId, dn *master_pb.DataNodeInfo) {
+ eachDataNode(topologyInfo, func(dc string, rack RackId, dn *master_pb.DataNodeInfo) {
loc := newLocation(dc, string(rack), dn)
for _, diskInfo := range dn.DiskInfos {
for _, v := range diskInfo.VolumeInfos {