aboutsummaryrefslogtreecommitdiff
path: root/weed/storage/volume_checking.go
diff options
context:
space:
mode:
authorChris Lu <chris.lu@gmail.com>2019-04-19 01:56:38 -0700
committerChris Lu <chris.lu@gmail.com>2019-04-19 01:56:38 -0700
commit0be2d51c96e4c2c05cad5ac3d6104ccb7e1adeb6 (patch)
tree6b5f3ed7ceb32941db2e7999a162a07da8fc543c /weed/storage/volume_checking.go
parentac2727853f94c8fc4e301a995997f02b70047853 (diff)
downloadseaweedfs-0be2d51c96e4c2c05cad5ac3d6104ccb7e1adeb6.tar.xz
seaweedfs-0be2d51c96e4c2c05cad5ac3d6104ccb7e1adeb6.zip
read volume lastAppendAtNs when loading a volume
Diffstat (limited to 'weed/storage/volume_checking.go')
-rw-r--r--weed/storage/volume_checking.go34
1 files changed, 17 insertions, 17 deletions
diff --git a/weed/storage/volume_checking.go b/weed/storage/volume_checking.go
index 9599885ec..980656823 100644
--- a/weed/storage/volume_checking.go
+++ b/weed/storage/volume_checking.go
@@ -9,28 +9,29 @@ import (
"github.com/chrislusf/seaweedfs/weed/util"
)
-func CheckVolumeDataIntegrity(v *Volume, indexFile *os.File) error {
+func CheckVolumeDataIntegrity(v *Volume, indexFile *os.File) (lastAppendAtNs uint64, e error) {
var indexSize int64
- var e error
if indexSize, e = verifyIndexFileIntegrity(indexFile); e != nil {
- return fmt.Errorf("verifyIndexFileIntegrity %s failed: %v", indexFile.Name(), e)
+ return 0, fmt.Errorf("verifyIndexFileIntegrity %s failed: %v", indexFile.Name(), e)
}
if indexSize == 0 {
- return nil
+ return 0,nil
}
var lastIdxEntry []byte
if lastIdxEntry, e = readIndexEntryAtOffset(indexFile, indexSize-NeedleMapEntrySize); e != nil {
- return fmt.Errorf("readLastIndexEntry %s failed: %v", indexFile.Name(), e)
+ return 0, fmt.Errorf("readLastIndexEntry %s failed: %v", indexFile.Name(), e)
}
key, offset, size := IdxFileEntry(lastIdxEntry)
- if offset.IsZero() || size == TombstoneFileSize {
- return nil
+ if offset.IsZero() {
+ return 0,nil
}
- if e = verifyNeedleIntegrity(v.dataFile, v.Version(), offset.ToAcutalOffset(), key, size); e != nil {
- return fmt.Errorf("verifyNeedleIntegrity %s failed: %v", indexFile.Name(), e)
+ if size == TombstoneFileSize {
+ size = 0
}
-
- return nil
+ if lastAppendAtNs, e = verifyNeedleIntegrity(v.dataFile, v.Version(), offset.ToAcutalOffset(), key, size); e != nil {
+ return lastAppendAtNs, fmt.Errorf("verifyNeedleIntegrity %s failed: %v", indexFile.Name(), e)
+ }
+ return
}
func verifyIndexFileIntegrity(indexFile *os.File) (indexSize int64, err error) {
@@ -52,14 +53,13 @@ func readIndexEntryAtOffset(indexFile *os.File, offset int64) (bytes []byte, err
return
}
-func verifyNeedleIntegrity(datFile *os.File, v needle.Version, offset int64, key NeedleId, size uint32) error {
+func verifyNeedleIntegrity(datFile *os.File, v needle.Version, offset int64, key NeedleId, size uint32) (lastAppendAtNs uint64, err error) {
n := new(needle.Needle)
- err := n.ReadData(datFile, offset, size, v)
- if err != nil {
- return err
+ if err = n.ReadData(datFile, offset, size, v); err != nil {
+ return n.AppendAtNs, err
}
if n.Id != key {
- return fmt.Errorf("index key %#x does not match needle's Id %#x", key, n.Id)
+ return n.AppendAtNs, fmt.Errorf("index key %#x does not match needle's Id %#x", key, n.Id)
}
- return nil
+ return n.AppendAtNs, err
}