1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
|
package engine
import (
"fmt"
"testing"
"github.com/seaweedfs/seaweedfs/weed/pb/schema_pb"
)
func TestArithmeticExpressionParsing(t *testing.T) {
tests := []struct {
name string
expression string
expectNil bool
leftCol string
rightCol string
operator string
}{
{
name: "simple addition",
expression: "id+user_id",
expectNil: false,
leftCol: "id",
rightCol: "user_id",
operator: "+",
},
{
name: "simple subtraction",
expression: "col1-col2",
expectNil: false,
leftCol: "col1",
rightCol: "col2",
operator: "-",
},
{
name: "multiplication with spaces",
expression: "a * b",
expectNil: false,
leftCol: "a",
rightCol: "b",
operator: "*",
},
{
name: "string concatenation",
expression: "first_name||last_name",
expectNil: false,
leftCol: "first_name",
rightCol: "last_name",
operator: "||",
},
{
name: "string concatenation with spaces",
expression: "prefix || suffix",
expectNil: false,
leftCol: "prefix",
rightCol: "suffix",
operator: "||",
},
{
name: "not arithmetic",
expression: "simple_column",
expectNil: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// Use CockroachDB parser to parse the expression
cockroachParser := NewCockroachSQLParser()
dummySelect := fmt.Sprintf("SELECT %s", tt.expression)
stmt, err := cockroachParser.ParseSQL(dummySelect)
var result *ArithmeticExpr
if err == nil {
if selectStmt, ok := stmt.(*SelectStatement); ok && len(selectStmt.SelectExprs) > 0 {
if aliasedExpr, ok := selectStmt.SelectExprs[0].(*AliasedExpr); ok {
if arithmeticExpr, ok := aliasedExpr.Expr.(*ArithmeticExpr); ok {
result = arithmeticExpr
}
}
}
}
if tt.expectNil {
if result != nil {
t.Errorf("Expected nil for %s, got %v", tt.expression, result)
}
return
}
if result == nil {
t.Errorf("Expected arithmetic expression for %s, got nil", tt.expression)
return
}
if result.Operator != tt.operator {
t.Errorf("Expected operator %s, got %s", tt.operator, result.Operator)
}
// Check left operand
if leftCol, ok := result.Left.(*ColName); ok {
if leftCol.Name.String() != tt.leftCol {
t.Errorf("Expected left column %s, got %s", tt.leftCol, leftCol.Name.String())
}
} else {
t.Errorf("Expected left operand to be ColName, got %T", result.Left)
}
// Check right operand
if rightCol, ok := result.Right.(*ColName); ok {
if rightCol.Name.String() != tt.rightCol {
t.Errorf("Expected right column %s, got %s", tt.rightCol, rightCol.Name.String())
}
} else {
t.Errorf("Expected right operand to be ColName, got %T", result.Right)
}
})
}
}
func TestArithmeticExpressionEvaluation(t *testing.T) {
engine := NewSQLEngine("")
// Create test data
result := HybridScanResult{
Values: map[string]*schema_pb.Value{
"id": {Kind: &schema_pb.Value_Int64Value{Int64Value: 10}},
"user_id": {Kind: &schema_pb.Value_Int64Value{Int64Value: 5}},
"price": {Kind: &schema_pb.Value_DoubleValue{DoubleValue: 25.5}},
"qty": {Kind: &schema_pb.Value_Int64Value{Int64Value: 3}},
"first_name": {Kind: &schema_pb.Value_StringValue{StringValue: "John"}},
"last_name": {Kind: &schema_pb.Value_StringValue{StringValue: "Doe"}},
"prefix": {Kind: &schema_pb.Value_StringValue{StringValue: "Hello"}},
"suffix": {Kind: &schema_pb.Value_StringValue{StringValue: "World"}},
},
}
tests := []struct {
name string
expression string
expected interface{}
}{
{
name: "integer addition",
expression: "id+user_id",
expected: int64(15),
},
{
name: "integer subtraction",
expression: "id-user_id",
expected: int64(5),
},
{
name: "mixed types multiplication",
expression: "price*qty",
expected: float64(76.5),
},
{
name: "string concatenation",
expression: "first_name||last_name",
expected: "JohnDoe",
},
{
name: "string concatenation with spaces",
expression: "prefix || suffix",
expected: "HelloWorld",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// Parse the arithmetic expression using CockroachDB parser
cockroachParser := NewCockroachSQLParser()
dummySelect := fmt.Sprintf("SELECT %s", tt.expression)
stmt, err := cockroachParser.ParseSQL(dummySelect)
if err != nil {
t.Fatalf("Failed to parse expression %s: %v", tt.expression, err)
}
var arithmeticExpr *ArithmeticExpr
if selectStmt, ok := stmt.(*SelectStatement); ok && len(selectStmt.SelectExprs) > 0 {
if aliasedExpr, ok := selectStmt.SelectExprs[0].(*AliasedExpr); ok {
if arithExpr, ok := aliasedExpr.Expr.(*ArithmeticExpr); ok {
arithmeticExpr = arithExpr
}
}
}
if arithmeticExpr == nil {
t.Fatalf("Failed to parse arithmetic expression: %s", tt.expression)
}
// Evaluate the expression
value, err := engine.evaluateArithmeticExpression(arithmeticExpr, result)
if err != nil {
t.Fatalf("Failed to evaluate expression: %v", err)
}
if value == nil {
t.Fatalf("Got nil value for expression: %s", tt.expression)
}
// Check the result
switch expected := tt.expected.(type) {
case int64:
if intVal, ok := value.Kind.(*schema_pb.Value_Int64Value); ok {
if intVal.Int64Value != expected {
t.Errorf("Expected %d, got %d", expected, intVal.Int64Value)
}
} else {
t.Errorf("Expected int64 result, got %T", value.Kind)
}
case float64:
if doubleVal, ok := value.Kind.(*schema_pb.Value_DoubleValue); ok {
if doubleVal.DoubleValue != expected {
t.Errorf("Expected %f, got %f", expected, doubleVal.DoubleValue)
}
} else {
t.Errorf("Expected double result, got %T", value.Kind)
}
case string:
if stringVal, ok := value.Kind.(*schema_pb.Value_StringValue); ok {
if stringVal.StringValue != expected {
t.Errorf("Expected %s, got %s", expected, stringVal.StringValue)
}
} else {
t.Errorf("Expected string result, got %T", value.Kind)
}
}
})
}
}
func TestSelectArithmeticExpression(t *testing.T) {
// Test parsing a SELECT with arithmetic and string concatenation expressions
stmt, err := ParseSQL("SELECT id+user_id, user_id*2, first_name||last_name FROM test_table")
if err != nil {
t.Fatalf("Failed to parse SQL: %v", err)
}
selectStmt := stmt.(*SelectStatement)
if len(selectStmt.SelectExprs) != 3 {
t.Fatalf("Expected 3 select expressions, got %d", len(selectStmt.SelectExprs))
}
// Check first expression (id+user_id)
aliasedExpr1 := selectStmt.SelectExprs[0].(*AliasedExpr)
if arithmeticExpr1, ok := aliasedExpr1.Expr.(*ArithmeticExpr); ok {
if arithmeticExpr1.Operator != "+" {
t.Errorf("Expected + operator, got %s", arithmeticExpr1.Operator)
}
} else {
t.Errorf("Expected arithmetic expression, got %T", aliasedExpr1.Expr)
}
// Check second expression (user_id*2)
aliasedExpr2 := selectStmt.SelectExprs[1].(*AliasedExpr)
if arithmeticExpr2, ok := aliasedExpr2.Expr.(*ArithmeticExpr); ok {
if arithmeticExpr2.Operator != "*" {
t.Errorf("Expected * operator, got %s", arithmeticExpr2.Operator)
}
} else {
t.Errorf("Expected arithmetic expression, got %T", aliasedExpr2.Expr)
}
// Check third expression (first_name||last_name)
aliasedExpr3 := selectStmt.SelectExprs[2].(*AliasedExpr)
if arithmeticExpr3, ok := aliasedExpr3.Expr.(*ArithmeticExpr); ok {
if arithmeticExpr3.Operator != "||" {
t.Errorf("Expected || operator, got %s", arithmeticExpr3.Operator)
}
} else {
t.Errorf("Expected string concatenation expression, got %T", aliasedExpr3.Expr)
}
}
|
