aboutsummaryrefslogtreecommitdiff
path: root/weed/query/engine/postgresql_only_test.go
blob: d98cab9f0a34a3272886f8a70f2177c6ed443090 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
package engine

import (
	"context"
	"strings"
	"testing"
)

// TestPostgreSQLOnlySupport ensures that non-PostgreSQL syntax is properly rejected
func TestPostgreSQLOnlySupport(t *testing.T) {
	engine := NewTestSQLEngine()

	testCases := []struct {
		name        string
		sql         string
		shouldError bool
		errorMsg    string
		desc        string
	}{
		// Test that MySQL backticks are not supported for identifiers
		{
			name:        "MySQL_Backticks_Table",
			sql:         "SELECT * FROM `user_events` LIMIT 1",
			shouldError: true,
			desc:        "MySQL backticks for table names should be rejected",
		},
		{
			name:        "MySQL_Backticks_Column",
			sql:         "SELECT `column_name` FROM user_events LIMIT 1",
			shouldError: true,
			desc:        "MySQL backticks for column names should be rejected",
		},

		// Test that PostgreSQL double quotes work (should NOT error)
		{
			name:        "PostgreSQL_Double_Quotes_OK",
			sql:         `SELECT "user_id" FROM user_events LIMIT 1`,
			shouldError: false,
			desc:        "PostgreSQL double quotes for identifiers should work",
		},

		// Note: MySQL functions like YEAR(), MONTH() may parse but won't have proper implementations
		// They're removed from the engine so they won't work correctly, but we don't explicitly reject them

		// Test that PostgreSQL EXTRACT works (should NOT error)
		{
			name:        "PostgreSQL_EXTRACT_OK",
			sql:         "SELECT EXTRACT(YEAR FROM CURRENT_DATE) FROM user_events LIMIT 1",
			shouldError: false,
			desc:        "PostgreSQL EXTRACT function should work",
		},

		// Test that single quotes work for string literals but not identifiers
		{
			name:        "Single_Quotes_String_Literal_OK",
			sql:         "SELECT 'hello world' FROM user_events LIMIT 1",
			shouldError: false,
			desc:        "Single quotes for string literals should work",
		},
	}

	passCount := 0
	for _, tc := range testCases {
		t.Run(tc.name, func(t *testing.T) {
			result, err := engine.ExecuteSQL(context.Background(), tc.sql)

			if tc.shouldError {
				// We expect this query to fail
				if err == nil && result.Error == nil {
					t.Errorf("❌ Expected error for %s, but query succeeded", tc.desc)
					return
				}

				// Check for specific error message if provided
				if tc.errorMsg != "" {
					errorText := ""
					if err != nil {
						errorText = err.Error()
					} else if result.Error != nil {
						errorText = result.Error.Error()
					}

					if !strings.Contains(errorText, tc.errorMsg) {
						t.Errorf("❌ Expected error containing '%s', got: %s", tc.errorMsg, errorText)
						return
					}
				}

				t.Logf("CORRECTLY REJECTED: %s", tc.desc)
				passCount++
			} else {
				// We expect this query to succeed
				if err != nil {
					t.Errorf("Unexpected error for %s: %v", tc.desc, err)
					return
				}

				if result.Error != nil {
					t.Errorf("Unexpected result error for %s: %v", tc.desc, result.Error)
					return
				}

				t.Logf("CORRECTLY ACCEPTED: %s", tc.desc)
				passCount++
			}
		})
	}

	t.Logf("PostgreSQL-only compliance: %d/%d tests passed", passCount, len(testCases))
}